Make the release script's own gate pass again - #14
Merged
Conversation
`scripts/release-local.sh` runs `cargo clippy --release --all-targets -D warnings` before it builds anything, and that gate has been failing: the glam 0.33 bump deprecated `Mat4::look_at_rh` and `Mat4::perspective_rh`, and clippy learned `chunks_exact_to_as_chunks`. Neither is a bug, and together they meant there was no way to build a local .app at all. The glam replacement needs saying out loud. 0.33 offers one perspective per clip space, named after the API that popularised each, and all three are right-handed: `vulkan` has wgpu's depth range with Y *down*, `opengl` puts Z in -1..1, and only `directx` is Z in 0..1 with Y up — what wgpu, and so Metal here, actually wants. Pick either of the others and the stage still renders, upside down or clipped at half its depth. The new matrices were checked equal to the old ones before the deprecated calls went, and a test now pins the clip space directly rather than trusting the module name. The About window is vendored from stoatworks-backend and says so in its header, so its one clippy nit is silenced at the `mod` instead of edited in a copy. Worth fixing upstream and re-syncing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/release-local.shrunscargo clippy --release --all-targets -- -D warningsbefore it builds anything, and that gate has been failing since the glam 0.33 bump — so there was no way to build a local.appat all.Mat4::look_at_rhandMat4::perspective_rh. 0.33 offers one perspective per clip space, all right-handed:vulkanis wgpu's depth range with Y down,openglputs Z in-1..1, and onlydirectxis Z in0..1with Y up — what wgpu, and so Metal here, actually wants. Pick either of the others and the stage still renders: upside down, or clipped at half its depth. The new matrices were checked equal to the old ones before the deprecated calls went, and a new test pins the clip space directly rather than trusting the module name.chunks_exact_to_as_chunksinunmapper-render— applied withcargo clippy --fix.stoatworks-backendand its header says to edit it there, so its one nit is silenced at themodrather than fixed in a copy. Worth fixing upstream and re-syncing.cargo clippy --all-targetsis now clean and all tests pass.🤖 Generated with Claude Code