mdns-sd 0.21: ServiceResolved now carries a ResolvedService - #24
Merged
Conversation
Bumps [mdns-sd](https://github.com/keepsimple1/mdns-sd) from 0.11.5 to 0.21.0. - [Release notes](https://github.com/keepsimple1/mdns-sd/releases) - [Changelog](https://github.com/keepsimple1/mdns-sd/blob/main/CHANGELOG.md) - [Commits](keepsimple1/mdns-sd@v0.11.5...v0.21.0) --- updated-dependencies: - dependency-name: mdns-sd dependency-version: 0.21.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Takes #22's bump with the source changes it needs. The ServiceResolved event used to hand back a ServiceInfo; in 0.21 it is a ResolvedService, which exposes plain fields rather than the get_* accessors: info.get_type() -> info.ty_domain info.get_addresses_v4() -> info.addresses, a HashSet<ScopedIp> ScopedIp carries the interfaces an address was seen on, so it is filtered with is_ipv4() and unwrapped with to_ip_addr() rather than being taken as a bare Ipv4Addr. Picking the first of a set was arbitrary before and still is; that has not changed. Verified: cargo build --all-targets clean, cargo test clean, failing set identical to main's (empty).
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #22, which cannot compile on its own.
ServiceEvent::ServiceResolvedused to hand back aServiceInfo. In 0.21 it carries aResolvedService, which exposes plain fields instead of theget_*accessors:info.get_type()info.ty_domaininfo.get_addresses_v4()info.addresses— aHashSet<ScopedIp>ScopedIprecords which interfaces an address was seen on, so it is no longer a bareIpv4Addr: filtered withis_ipv4()and unwrapped withto_ip_addr().Behaviour is unchanged — taking the first entry of a set was already arbitrary, and still is.
Verified locally:
cargo build --all-targetsclean,cargo testclean — failing set identical to main's (both empty).