Skip to content

ACM-36695 [Backport release-2.15] Preserve newlines in CSV export to match console rendering #6436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Randy424 wants to merge 1 commit into
base: release-2.15
Choose a base branch
from
Open

ACM-36695 [Backport release-2.15] Preserve newlines in CSV export to match console rendering #6436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions frontend/src/resources/utils/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,14 @@ export function exportObjectString(object: Record<string, string>) {
return keyValueMap.toString()
}

export function returnCSVSafeString(exportValue: string | ReactNode) {
// extract newlines
return `"${typeof exportValue === 'string' ? exportValue.split('\n').join(' ').replace(/"/g, '""') : exportValue}"`
export function returnCSVSafeString(exportValue: string | number | ReactNode) {
if (typeof exportValue === 'number') {
return `"${exportValue}"`
}
if (typeof exportValue !== 'string') {
return '"-"'
}
return `"${exportValue.replaceAll('"', '""')}"`
}

export const getISOStringTimestamp = (timestamp: string) => {
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/ui-components/AcmTable/AcmTable.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,10 +1146,10 @@ describe('AcmTable', () => {
})

describe('returnCSVSafeString', () => {
test('returns a csv safe string replacing new line with space', () => {
test('returns a csv safe string preserving newlines', () => {
const content = 'testing for multiline\ndescription'
const exportContent = returnCSVSafeString(content)
expect(exportContent).toEqual('"testing for multiline description"')
expect(exportContent).toEqual('"testing for multiline\ndescription"')
})

test('returns a csv safe string escaping double quotes', () => {
Expand Down