Skip to content

ACM-44889: fix non-admin SSE OOM on release-2.15 - #6840

Draft
Ginxo wants to merge 4 commits into
stolostron:release-2.15from
Ginxo:ACM-44889
Draft

Ginxo wants to merge 4 commits into
stolostron:release-2.15from
Ginxo:ACM-44889

Conversation

@Ginxo

@Ginxo Ginxo commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • npm run test:backend
  • npm run check:backend

Made with Cursor

Ginxo and others added 2 commits September 15, 2026 00:38
Port SelfSubjectRulesReview short-circuit, access-cache hardening,
eventsDefinitions/CLUSTER_SCOPED_KINDS, and filter-before-inflate SSE
from stolostron#6638 so restricted users no longer OOM the console backend.

Signed-off-by: Enrique Mingorance Cano <emingora@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Cover access cache, SelfSubjectRulesReview short-circuit, cluster-scoped
routing, and filter-before-inflate behavior.

Signed-off-by: Enrique Mingorance Cano <emingora@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ginxo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown

@Ginxo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/pr-image-mirror-mce fc68ee7 link true /test pr-image-mirror-mce
ci/prow/pr-image-mirror fc68ee7 link true /test pr-image-mirror

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sonarqubecloud

Copy link
Copy Markdown

@Ginxo
Ginxo marked this pull request as draft September 15, 2026 06:15
Ginxo and others added 2 commits September 16, 2026 09:34
That option was introduced in 2.17; 2.16 and older always broadcast cached
watch events. Keep clusterScoped and SSE meta/filter-before-inflate only.

Signed-off-by: Enrique Mingorance Cano <emingora@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Drop the test-only reset export and align observability cache tests
with the upstream initialObsFlag pattern.

Signed-off-by: Enrique Mingorance Cano <emingora@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant