Conversation
Port SelfSubjectRulesReview short-circuit, access-cache hardening, eventsDefinitions/CLUSTER_SCOPED_KINDS, and filter-before-inflate SSE from stolostron#6638 so restricted users no longer OOM the console backend. Signed-off-by: Enrique Mingorance Cano <emingora@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Cover access cache, SelfSubjectRulesReview short-circuit, cluster-scoped routing, and filter-before-inflate behavior. Signed-off-by: Enrique Mingorance Cano <emingora@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ginxo The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Ginxo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
That option was introduced in 2.17; 2.16 and older always broadcast cached watch events. Keep clusterScoped and SSE meta/filter-before-inflate only. Signed-off-by: Enrique Mingorance Cano <emingora@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Drop the test-only reset export and align observability cache tests with the upstream initialObsFlag pattern. Signed-off-by: Enrique Mingorance Cano <emingora@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
1 participant
Summary
release-2.14(ACM-39327 / ACM-44890).Promise.allinstead ofbatch-promise-all(not present on 2.14);eventsDefinitionsmatches the 2.14 watch list.Test plan
npm run test:backendnpm run check:backendMade with Cursor