[backplane-5.0] [ACM-42853] Add missing webhook containerPort declaration - #2338
Conversation
The discovery-operator's validating webhook was added without a corresponding containerPort declaration in the deployment manifest. This went unnoticed until a NetworkPolicy enforcing port-based ingress rules was introduced, at which point the webhook became unreachable and all DiscoveredCluster create/update operations began failing with context deadline exceeded timeouts. - Add containerPort: 9443 (name: webhook-server) to the discovery-operator container spec in config/manager/manager.yaml - Regenerate bundle/manifests/discovery.clusterserviceversion.yaml via make manifests && make bundle to reflect the new port declaration Signed-off-by: dislbenn <dbennett@redhat.com>
The discovery-operator-allow-webhook NetworkPolicy combined a
namespaceSelector (matching the special openshift-host-network virtual
namespace) with a podSelector: {} in the same 'from' entry.
Verified on a live OVN-Kubernetes cluster that this combination causes
ingress traffic from host-network pods (i.e. kube-apiserver, which
performs admission webhook calls for the DiscoveredCluster CRD) to be
silently dropped, even though the namespaceSelector alone matches
correctly. Removing the redundant podSelector restores connectivity.
Without this fix, DiscoveredCluster create/update/delete operations
fail with 'context deadline exceeded' calling the webhook, even when
containerPort: 9443 is correctly declared on the deployment.
Signed-off-by: dislbenn <dbennett@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dislbenn, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
b95864b
into
stolostron:backplane-5.0
2 participants
This is an automated cherry-pick of #2337
/assign dislbenn