Skip to content

[ACM-43178][ACM-41605] chore: bump go.mod directive to 1.26.7 - #2346

Merged
openshift-merge-bot[bot] merged 1 commit into
stolostron:mainfrom
ngraham20:chore/bump-go-directive-1.26.7
Sep 2, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
stolostron:mainfrom
ngraham20:chore/bump-go-directive-1.26.7

Conversation

@ngraham20

Copy link
Copy Markdown
Contributor

Fixes ACM-43178
Fixes ACM-41605

Z-stream trackers (CVE-2026-42504): ACM-42896, ACM-42899, ACM-42900, ACM-42901, ACM-42906
Z-stream trackers (CVE-2026-56862): ACM-41271, ACM-41272, ACM-41274, ACM-41275, ACM-41276

CVEs resolved by this change:

CVE GO advisory Fixed in
CVE-2026-42504 (mime DoS) GO-2026-5038 1.26.4
CVE-2026-56860 (net/url DoS) GO-2026-6218 1.26.6
CVE-2026-56862 (crypto/tls DoS) GO-2026-6090 1.26.6
CVE-2026-56853 (net/http DoS) GO-2026-6089 1.26.6
CVE-2026-56859 (encoding/xml DoS) GO-2026-6088 1.26.6
CVE-2026-33818 (encoding/asn1 DoS) GO-2026-5972 1.26.6
CVE-2026-39821 (x/net/idna) GO-2026-5026 1.26.6

Change: go.mod directive 1.26.31.26.7

Context: go.mod was stale relative to what's actually shipping — the Dockerfile builds from the floating golang:1.26 tag, and the currently published discovery-operator:latest image (built from main) already embeds go1.26.5. This bump closes the gap between the declared minimum and reality, and picks up the remaining fixes through 1.26.7.

Manual follow-up (not changed by this PR): Dockerfile pins FROM golang:1.26 (floating minor tag, no digest). This will resolve to whatever patch is current at build time — recommend evaluating whether to pin to a specific patch/digest for build reproducibility, independent of this PR.

Validation: go build -mod=readonly ./..., go vet ./..., gofmt -l . all pass with a locally installed go1.26.7 toolchain. No unit test run (per team's standard practice for this class of change).

Aligns the declared Go minimum with the toolchain already resolved by
the floating golang:1.26 builder tag in production builds (observed
go1.26.5 in the currently published discovery-operator:latest image),
and closes coverage gaps for 6 stdlib CVEs only fixed in 1.26.6:

- GO-2026-6218 (CVE-2026-56860)
- GO-2026-6090 (CVE-2026-56862)
- GO-2026-6089 (CVE-2026-56853)
- GO-2026-6088 (CVE-2026-56859)
- GO-2026-5972 (CVE-2026-33818)
- GO-2026-5026 (CVE-2026-39821)

Verified with go build (-mod=readonly), go vet, and gofmt against a
locally installed go1.26.7 toolchain.

Signed-off-by: Nathaniel Graham <ngraham@redhat.com>
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 82b0cb3c-e70e-4f2d-b9cd-c42763643c86


Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested a review from dislbenn September 1, 2026 21:46
@openshift-ci openshift-ci Bot added the approved PR approval has been given label Sep 1, 2026
@sonarqubecloud

sonarqubecloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

@dislbenn

dislbenn commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Sep 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn, ngraham20

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 8f66977 into stolostron:main Sep 2, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR approval has been given dco-signoff: yes lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants