fix(smithy): release agent pool slots on session end#124
Open
furquanuddin94 wants to merge 10 commits into
Open
fix(smithy): release agent pool slots on session end#124furquanuddin94 wants to merge 10 commits into
furquanuddin94 wants to merge 10 commits into
Conversation
Extract the Codex interactive argument construction into buildCodexInteractiveArgs so the unit test exercises the same production arg-building logic used by spawn instead of duplicating that logic in the test. The helper preserves the existing working-directory, resume, and model behavior. Codex now documents --sandbox workspace-write as the replacement for the deprecated --full-auto shortcut, so use the documented sandbox flag for fresh and resumed interactive sessions. Refs stoneforge-ai#114.
…-flag fix(smithy): update codex interactive sandbox flag
fix: capture Codex interactive resume IDs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #121.
Agent pool slots are now released when worker or steward sessions terminate, including sessions cleaned up after dead-process detection. This prevents pools from staying full when no governed session is actually running.
Stacking note
This PR is stacked on upstream PRs #116 and #118. The agent-pool fix itself is in the top five commits on this branch:
ff02229fix(smithy): release agent pool slots on session end1f888ecfix(smithy): keep pool slots tied to active agentse2945dbfix(smithy): reserve pool slots before session start218eafcfix(smithy): wait for session end cleanup before restart1705e4ddocs: clarify agent pool changesetChanges
SessionManagerso pool cleanup can run when sessions leave active execution.Test plan
bun test packages/smithy/src/runtime/session-manager.bun.test.tsbun test packages/smithy/src/services/agent-pool-service.bun.test.tsbun test packages/smithy/src/services/dispatch-daemon.bun.test.tscorepack pnpm --filter @stoneforge/smithy typecheckgit diff --checkChecklist