-
Notifications
You must be signed in to change notification settings - Fork 251
Handled Active Element of Table of Content #2853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for stoplight-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stoplight-elements-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@SB-venkatyadavilli @SB-ChetanKorde Any chance you guys can have a look at PRs in json-schema-viewer? For example, stoplightio/json-schema-viewer#293 |
|
Please add details for ticket/issue and fix implemented. Also attach testing evidences in PR description. |
packages/elements-core/src/components/TableOfContents/TableOfContents.spec.tsx
Outdated
Show resolved
Hide resolved
packages/elements-core/src/components/TableOfContents/TableOfContents.tsx
Outdated
Show resolved
Hide resolved
packages/elements-core/src/components/TableOfContents/TableOfContents.tsx
Outdated
Show resolved
Hide resolved
packages/elements-core/src/components/TableOfContents/TableOfContents.tsx
Outdated
Show resolved
Hide resolved
packages/elements-core/src/components/TableOfContents/TableOfContents.tsx
Outdated
Show resolved
Hide resolved
packages/elements-core/src/components/TableOfContents/TableOfContents.tsx
Outdated
Show resolved
Hide resolved
packages/elements-core/src/components/TableOfContents/TableOfContents.stories.tsx
Show resolved
Hide resolved
darekplawecki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now looks good, thanks!
prafullaAtSB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are good to go ahead.
Elements Default PR Template
STOP-4166
Description
Previously, if the same item appeared multiple times in the Table of Contents, clicking on any instance would highlight all occurrences as active. With this fix, only the clicked element is shown as active, while all other instances remain inactive.
Handled Active Element of Table Of Content.
How Has This Been Tested?
Tested by running elements-dev-portal storybook and Yalc testing.
Screenshot(s)/recordings(s)
Before:
After:
4166-artifacts.mov
CONTRIBUTING.md