-
Notifications
You must be signed in to change notification settings - Fork 251
Doc View Crashing when selecting Enum value #2859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for stoplight-elements-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stoplight-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
prafullaAtSB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks common code of encodeSafeSelectorValue method here and at packages/elements-core/src/components/TryIt/Servers/VariableEditor.tsx
create utility class and use it at both place.
|
@prafullaAtSB , I have removed the redundant code. |
prafullaAtSB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to go ahead after comments incorporating..
Motivation and Context
STOP-4423
Description
Elements crash when user tries to apply query parameter to try request
How Has This Been Tested?
Screenshot(s)/recordings(s)
Types of changes
Checklist
s/needs-docslabel.