This repository was archived by the owner on Jan 19, 2026. It is now read-only.
Introduce Datasource Filtering on sync command based on Name and Slug#52
Open
CaprinaeWT wants to merge 15 commits into
Open
Introduce Datasource Filtering on sync command based on Name and Slug#52CaprinaeWT wants to merge 15 commits into
CaprinaeWT wants to merge 15 commits into
Conversation
…g && --datasources-starts-with-name
…g and --datasources-starts-with-name to sync command
…ry-filter fix: revert starts-with and filter query features
…fault-header feat(int-978): adding default header for all requests
Member
ademarCardoso
left a comment
ademarCardoso
left a comment
There was a problem hiding this comment.
I really liked the feature, congrats man and thank you so much for the contribution 💪🏼
Please, fix the conflicts and take a look on my comments and we can proceed with the merge 😄
ademarCardoso
suggested changes
Aug 9, 2023
Member
ademarCardoso
left a comment
ademarCardoso
left a comment
There was a problem hiding this comment.
Please my friend, take a look into my comments, you refactored several files, which i believe are not needed for a feature you implemented, please revert 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Jira Link: INT-
How to test this PR
Run the following command to test the datasource filtering feature by slug:
./cli.js sync --type datasources <source-space-id> --target <target-space-id> --datasources-starts-with-slug globalAn example of the terminal output: datasources where the slug starts with "global": global-translations-Mobility, global-projects.
Test the datasource filtering feature by name using the following command:
./cli.js sync --type datasources <source-space-id> --target <target-space-id> --datasources-starts-with-name globalAn example of the terminal output: datasources where the slug starts with "global": Global Translations Mobility, Global Projects.
Verify that only the datasources belonging to the specified name and/or slug are synchronized between the source and target. Datasources that do not match the specified name and/or slug should not be synchronized.
Experiment with different combinations of name and/or slug to ensure that the filtering feature functions as expected.
Please note that the --datasources-starts-with-slug and --datasources-starts-with-name options enable filtering based on the provided name and/or slug. Replace and with the actual values of the source space and target space.
What is the new behavior?
This pull request introduces a new feature that enhances the datasource synchronization by allowing filtering based on the name and/or slug of the datasources. With this feature, users can selectively synchronize only the datasources that match the specified name and/or slug, providing a more efficient way to manage a large number of data sources across different projects.
Other information