Skip to content

ci(release): build through the wrapper, drop the stale ignore line #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stozo04 merged 2 commits into from
Sep 7, 2026
Merged

ci(release): build through the wrapper, drop the stale ignore line #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2aa8d99
chore: stop ignoring gradle-wrapper.jar
stozo04 Sep 7, 2026
0bbb90b
ci(release): build through the wrapper now that the jar is tracked
stozo04 Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 9 additions & 19 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,26 +162,11 @@ jobs:
- name: Set up Android SDK
uses: android-actions/setup-android@v3

# gradle-wrapper.jar is gitignored in this repo (.gitignore), so ./gradlew has no engine
# behind it on a fresh checkout. Take the version the wrapper pins and have setup-gradle
# provide exactly that — same Gradle the wrapper would have downloaded, read from the same
# file, so upgrading the wrapper still moves CI with it.
- name: Read the pinned Gradle version
id: gradle_version
run: |
set -euo pipefail
version=$(grep -oP 'gradle-\K[0-9.]+(?=-bin\.zip)' gradle/wrapper/gradle-wrapper.properties)
if [[ -z "$version" ]]; then
echo "::error::Could not read the Gradle version from gradle/wrapper/gradle-wrapper.properties."
exit 1
fi
echo "version=$version" >> "$GITHUB_OUTPUT"
echo "Wrapper pins Gradle $version"

# Takes the Gradle version from gradle/wrapper/gradle-wrapper.properties, and from v4 also
# checksums gradle-wrapper.jar against Gradle's published hashes on every run — which is what
# makes committing that jar safe.
- name: Set up Gradle
uses: gradle/actions/setup-gradle@v4
with:
gradle-version: ${{ steps.gradle_version.outputs.version }}

# keystore.properties and google-services.json are both gitignored, so CI has to
# reconstitute them. Actions masks these values in the log.
Expand Down Expand Up @@ -213,7 +198,12 @@ jobs:
echo "Keystore opens and contains the alias."

- name: Build the release bundle
run: gradle :app:bundleRelease --no-daemon --stacktrace
run: |
set -euo pipefail
# git on Windows does not track the executable bit, so gradlew is mode 100644 in the
# index and arrives non-executable on a Linux runner. Set it rather than assume it.
chmod +x gradlew
./gradlew :app:bundleRelease --no-daemon --stacktrace

- name: Verify the signature
id: sign
Expand Down
6 changes: 4 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,12 @@ keystore.properties
local/
docs/local/

# Files generated by Gradle
# Files generated by Gradle. NOTE: gradle/wrapper/gradle-wrapper.jar is deliberately TRACKED, not
# ignored — it is what makes ./gradlew work on a clean clone with no Gradle installed, and CI
# cannot build without it. gradle/actions/setup-gradle checksums it against Gradle's published
# hashes on every run, so the usual "don't commit binaries" worry is covered. Do not re-add it here.
.gradle
/local.properties
/gradle/wrapper/gradle-wrapper.jar

# Kotlin build-session data (Kotlin Gradle plugin 2.x)
.kotlin/
Expand Down