Skip to content

fix(release): drop the dead tools package from the Android SDK setup - #198

Merged
stozo04 merged 1 commit into
mainfrom
claude/festive-franklin-4pixad
Sep 17, 2026
Merged

stozo04 merged 1 commit into
mainfrom
claude/festive-franklin-4pixad

Conversation

@stozo04

@stozo04 stozo04 commented Sep 17, 2026

Copy link
Copy Markdown
Owner

android-actions/setup-android defaults packages to tools platform-tools. tools — the obsolete Android SDK Tools — no longer exists in Google's repository, so sdkmanager exits 1 with "Warning: Failed to find package 'tools'" and the release job dies at "Set up Android SDK".

That is worse than a normal red build because of where it lands: the bump PR has already been opened and merged by then. Run #7 (2026-09-17) left main at 1.0.53 with no bundle and no tag, which is the state the cut-release skill handles with dry_run: true rather than a second bump.

The v4 tag carries the same default, so pinning a newer action does not fix it — the list has to be overridden. Nothing downstream wants the dead package: bundleRelease lets AGP fetch the platform and build-tools it needs, and the signature check is jarsigner from the JDK. Keeping platform-tools makes this the default list minus the package Google removed, and nothing else.

release.yml is the only workflow that sets up the Android SDK.

Claude-Session: https://claude.ai/code/session_01FBjSmDxvBq7XtFE9PA28Ko

Description

Please include a summary of the change, the motivation behind it, and what problem it solves. Include relevant context and list any dependencies that are required for this change.

Related Issue

Fixes # (issue number, if applicable)

Type of Change

  • Feature: A new feature (non-breaking change which adds functionality)
  • 🐛 Bug Fix: A bug fix (non-breaking change which fixes an issue)
  • 🎨 Design/Style: Visual changes, layouts, animations, or asset integrations
  • ⚙️ Refactor: Code changes that neither fix a bug nor add a feature
  • 📝 Documentation: Changes or additions to documentation/guides
  • 🔧 Chore: Build configuration changes, dependency updates, or toolchain adjustments

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Manual Verification: (e.g., tested on Pixel 7 API 34, verified permission flow)
  • Automated Tests: (e.g., ran Gradle compile tasks)

Checklist

  • 🧪 My changes have been verified locally and work as expected.
  • 🔍 I have performed a self-review of my own code.
  • ✍️ I have commented my code, particularly in hard-to-understand areas.
  • 📖 My changes generate no compile warnings or errors (allWarningsAsErrors is on).
  • 🧹 Pre-PR sweep GREEN on the final commit (.\scripts\pre-pr-sweep.ps1build/sweep-receipt.json): build 0 e:/0 w:, zipalign, Lint 0/0, tests 0 failures, Markdown/tables/links/cspell/JSON at zero, onboarding loop PASS (or SKIPPED — not done). Inspect Code export: parsed to 0 / SKIPPED because: ______
  • 🏪 Play-facing docs aligned: if this PR changes permissions, data collection, file storage, or user-facing features/lenses — privacy policy (MD + HTML), data safety, and store listing updated to match (docs/DEFINITION_OF_DONE.md).
  • 🧹 The git branch is clean and references to obsolete branches have been pruned.

Note

Low Risk
CI-only change to Android SDK package list; no app runtime, auth, or signing logic changes.

Overview
Fixes release CI failing at Set up Android SDK after the version-bump PR has already merged. android-actions/setup-android defaults to installing tools and platform-tools, but Google removed the obsolete tools package, so sdkmanager exits with an error and the signed AAB never builds (e.g. run #7 left 1.0.53 without a bundle or tag).

The workflow now passes packages: 'platform-tools' only, with inline comments explaining why upgrading the action does not help. bundleRelease still pulls platform/build-tools via AGP; signing verification stays on JDK jarsigner.

Adds sdkmanager to cspell and the IDE project dictionary for the new workflow comments.

Reviewed by Cursor Bugbot for commit 62810fb. Bugbot is set up for automated code reviews on this repo. Configure here.

`android-actions/setup-android` defaults `packages` to `tools platform-tools`.
`tools` — the obsolete Android SDK Tools — no longer exists in Google's
repository, so sdkmanager exits 1 with "Warning: Failed to find package
'tools'" and the release job dies at "Set up Android SDK".

That is worse than a normal red build because of where it lands: the bump PR
has already been opened and merged by then. Run #7 (2026-09-17) left `main` at
1.0.53 with no bundle and no tag, which is the state the cut-release skill
handles with `dry_run: true` rather than a second bump.

The `v4` tag carries the same default, so pinning a newer action does not fix
it — the list has to be overridden. Nothing downstream wants the dead package:
`bundleRelease` lets AGP fetch the platform and build-tools it needs, and the
signature check is `jarsigner` from the JDK. Keeping `platform-tools` makes
this the default list minus the package Google removed, and nothing else.

`release.yml` is the only workflow that sets up the Android SDK.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FBjSmDxvBq7XtFE9PA28Ko
@stozo04
stozo04 merged commit 50c4ed3 into main Sep 17, 2026
3 checks passed
@stozo04
stozo04 deleted the claude/festive-franklin-4pixad branch September 17, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants