Conversation
Remove buildCompleteNotification function, its test, and two unused string resources that had zero callers in production or test code. Worker only uses buildProgressNotification and createForegroundInfo. Deleted: - BoomerangRenderNotifications.buildCompleteNotification() - BoomerangRenderNotificationsRobolectricTest.buildCompleteNotification_usesImmutablePendingIntent() - notification_loop_export_complete_title string resource - notification_loop_export_complete_text string resource No behavior change. Co-authored-by: Steven Gates <gates.steven@gmail.com>
stozo04
commented
Sep 18, 2026
stozo04
left a comment
Owner
Author
There was a problem hiding this comment.
looks right for tonight's cleanup. dead buildCompleteNotification + unused complete strings + the orphaned robolectric test for it — net -31, progress/FGS path untouched. no behavior change. ready when you are — still draft.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove dead loop-export "complete" notification surface that has zero callers in production or test code.
What was removed:
BoomerangRenderNotifications.buildCompleteNotification()function (lines 63–81)BoomerangRenderNotificationsRobolectricTest.buildCompleteNotification_usesImmutablePendingIntent()testnotification_loop_export_complete_titlestring resourcenotification_loop_export_complete_textstring resourceWhat remains (actively used):
buildProgressNotification— used by the worker during rendercreateForegroundInfo— the foreground service entry pointVerified via grep: no remaining references to
buildCompleteNotificationor the deleted string resources exist in the codebase.Related Issue
N/A — routine cleanup of unreachable code
Type of Change
How Has This Been Tested?
Checklist
allWarningsAsErrorsis on). (CI will verify)