Repository navigation
init: add the INTERNET permission Flutter/Android release builds need (0.3.3) - #15
Merged
Merged
Conversation
…lds; 0.3.3 Flutter's template declares android.permission.INTERNET only in the debug and profile manifests (an Android Studio template has none), so a release build set up with `strait init` could not reach Strait: no deferred match, no install row (QA 9 Nov 2026). init now adds the one line after <manifest> when it is missing: once (a second run leaves the file alone), matching the file's indent and line endings, ignoring a commented-out copy. Listed under "Edited:"; --dry-run shows it without writing; a run refused for an existing integration file writes nothing. With no manifest found, the printed manifest step carries the line. React Native and Expo are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strait initfor Flutter left outandroid.permission.INTERNET: Flutter's template only declares it for debug and profile builds, so a release build can't reach Strait (QA 9 Nov 2026:reason=network, 0 rows). Android Studio templates have none at all, so Kotlin apps get it too. React Native and Expo templates already have it.<uses-permission android:name="android.permission.INTERNET" />right after<manifest>when missing; idempotent; keeps indent and CRLF; ignores a commented-out copy.--dry-runshows it and writes nothing; a refused run (existinglib/links.dart) writes nothing.Tests: +6 (red first: missing export), 96 pass / 2 skipped.
Real thing: fresh
flutter create(Flutter 3.47.9) →strait init→ main manifest 0 → 1 INTERNET (second run unchanged) →flutter build apk --release→aapt2 dump permissionslists INTERNET (ops/run-1109/cli-web-followups/cli-flutter-release-proof.txt).🤖 Generated with Claude Code