fix(ollama): avoid UnboundLocalError on empty model stream#2823
Open
he-yufeng wants to merge 1 commit into
Open
fix(ollama): avoid UnboundLocalError on empty model stream#2823he-yufeng wants to merge 1 commit into
he-yufeng wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OllamaModel.streamreadseventafter theasync for event in responseloop to build themessage_stopandmetadatachunks. When the model returns an empty stream (no chunks at all),eventis never bound, soevent.done_reasonraisesUnboundLocalErrorinstead of closing the turn cleanly.Repro against current
main:Fix:
event = Nonebefore the loopNonefor the stop reason when there was no event (format_chunkalready maps anything that is nottool_use/lengthtoend_turn)metadatachunk when no event arrived, since there is no usage to reportThis mirrors what
GeminiModel.streamalready does for the empty-stream case, so the providers stay consistent. An empty stream now ends with a normalmessageStop(end_turn)and no metadata chunk.Related Issues
None tracked; found while auditing the model providers for the empty-stream edge case.
Documentation PR
Not needed, no public API or behavior change beyond not raising.
Type of Change
Bug fix
Testing
Added
test_stream_empty_response, which fails onmainwith theUnboundLocalErrorabove and passes with the fix.Checklist