fix(openai): handle non-string error code in classifyOpenAIError#2850
Open
chaodu-agent wants to merge 1 commit into
Open
fix(openai): handle non-string error code in classifyOpenAIError#2850chaodu-agent wants to merge 1 commit into
chaodu-agent wants to merge 1 commit into
Conversation
The OpenAI SDK's APIError.code field is typed as string but can be a number at runtime when the upstream API (e.g., OpenRouter) returns a numeric error code in the response body. This causes a TypeError when calling .toLowerCase() on the value. Use typeof guard to safely handle non-string code values.
github-actions
Bot
added
size/xs
typescript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
classifyOpenAIErrorcrashes withTypeError: err.code?.toLowerCase is not a functionwhen used with OpenAI-compatible APIs (e.g., OpenRouter) that return a numericcodein error responses.Root Cause
The OpenAI SDK's
APIErrorclass declarescode: string | null | undefinedbut assigns it directly from the response body without type coercion (this.code = data?.['code']). When an OpenAI-compatible provider like OpenRouter returns{ "error": { "code": 400, ... } },err.codeis a number at runtime.classifyOpenAIErrorthen callserr.code?.toLowerCase()which throws becauseNumber.prototypehas notoLowerCasemethod.Fix
Use a
typeofguard before calling.toLowerCase():Also widened the type signature to
code?: string | numberto reflect runtime reality.Testing
errors.test.tscontinue to passReproduction
Use the OpenAI model provider with OpenRouter's endpoint (
https://openrouter.ai/api/v1) and trigger any error — the agent crashes instead of classifying the error properly.