Skip to content

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Aug 19, 2025

Related stratis-storage/project#807

Summary by CodeRabbit

  • Chores
    • Updated CI workflow checkout to a newer version and disabled credential persistence to improve security and reliability.
    • Removed the weekly automated documentation checks workflow, stopping scheduled weekly docs/CI validations.
    • No changes to product functionality; infrastructure and automation updates only.

@mulkieran mulkieran self-assigned this Aug 19, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 19, 2025

Walkthrough

Updated .github/workflows/main.yml to bump actions/checkout from v4 to v5 and add with: persist-credentials: false in three jobs. Deleted .github/workflows/weekly.yml, removing the weekly "stratis-docs" automated checks workflow entirely.

Changes

Cohort / File(s) Summary
Workflow checkout updates
.github/workflows/main.yml
In jobs docs-checks, ci-checks, and spelling-checks: upgraded actions/checkout@v4actions/checkout@v5 and added with: persist-credentials: false. No other logic changes.
Removed scheduled workflow
.github/workflows/weekly.yml
Deleted file that provided weekly stratis-docs checks (two jobs running Fedora-based checks). This removes the weekly schedule and its jobs; no replacement added.

Sequence Diagram(s)

sequenceDiagram
  participant GitHub as GitHub Actions
  participant Repo as Repository
  participant Runner as Job Runner

  rect rgba(135,206,250,0.12)
    Note over GitHub,Runner: main.yml (updated)
    GitHub->>Repo: trigger job (docs/ci/spelling)
    Repo->>Runner: checkout (actions/checkout@v5, persist-credentials:false)
    Runner->>Runner: run job steps
  end

  rect rgba(220,220,220,0.08)
    Note over GitHub: weekly.yml removed
    GitHub--x Repo: no weekly trigger / no scheduled jobs
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

Poem

I hop through YAML fields at night,
Swapping checkouts, trimming white.
Weekly job hopped off the lawn,
Three jobs wake to v5 at dawn.
Thump—CI neat and shining bright! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8a3f523 and 10e0e01.

📒 Files selected for processing (2)
  • .github/workflows/main.yml (3 hunks)
  • .github/workflows/weekly.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/weekly.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/main.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: docs-checks
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mulkieran mulkieran moved this to In Review in 2025August Aug 19, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.github/workflows/main.yml (1)

51-53: Nit: consider checking out before installing dependencies to fail fast.

In the other jobs, checkout is first. Moving this checkout step above the dnf installs would avoid spending time installing packages if checkout fails (network/permissions/etc.). Functional behavior remains the same either way.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3029bcd and 8a3f523.

📒 Files selected for processing (1)
  • .github/workflows/main.yml (3 hunks)
🔇 Additional comments (1)
.github/workflows/main.yml (1)

34-36: Consistent change looks good here as well.

Same benefits as above; no incompatibilities expected with the Fedora container.

It's not really useful anymore.

Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran merged commit 0156f07 into stratis-storage:master Aug 19, 2025
5 checks passed
@mulkieran mulkieran deleted the issue_project_807 branch August 19, 2025 20:51
@github-project-automation github-project-automation bot moved this from In Review to Done in 2025August Aug 19, 2025
@mulkieran mulkieran moved this from Done to Done(3) in 2025August Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done(3)

Development

Successfully merging this pull request may close these issues.

1 participant