Increase CURRENT DEVELOPMENT ENVIRONMENT to Fedora 42 #3928

mulkieran · 2025-10-23T16:49:40Z

coderabbitai · 2025-10-23T16:50:04Z

Walkthrough

The PR updates Fedora container images from fedora:41 to fedora:42 across multiple GitHub Actions workflow files and adds libatomic to the dependency installation in the support workflow.

Changes

Cohort / File(s)	Summary
Fedora container version bump `/.github/workflows/cargo.yml`, `/.github/workflows/fedora.yml`, `/.github/workflows/main.yml`, `/.github/workflows/nightly.yml`, `/.github/workflows/valgrind.yml`	Replaced `fedora:41` with `fedora:42` in job container image declarations.
Support workflow update `/.github/workflows/support.yml`	Replaced `fedora:41` with `fedora:42` and added `libatomic` to the package installation step.

Sequence Diagram(s)

(No sequence diagram — changes are environment/image updates only.)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Files are homogeneous, containing straightforward image tag replacements and a single dependency addition.

Review /.github/workflows/support.yml to confirm libatomic is installed in the correct step and available for intended jobs.

Possibly related PRs

Stop checking rust dependency versions on Fedora 41 #3929 — Also modifies Fedora CI workflow entries and related Fedora 41 references.

Poem

🐰 Fedora hops, a quiet, tiny tune,
Forty-one steps back, forty-two greets the moon.
A libatomic nibble joins the tasty stew,
Workflows refreshed — a hop, a build, anew! 🚀

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: updating the development environment container image to Fedora 42 across multiple GitHub Actions workflows.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 36fe3d6 and 5e3662f.

📒 Files selected for processing (6)

.github/workflows/cargo.yml (1 hunks)
.github/workflows/fedora.yml (3 hunks)
.github/workflows/main.yml (6 hunks)
.github/workflows/nightly.yml (4 hunks)
.github/workflows/support.yml (1 hunks)
.github/workflows/valgrind.yml (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (5)

.github/workflows/nightly.yml
.github/workflows/fedora.yml
.github/workflows/valgrind.yml
.github/workflows/main.yml
.github/workflows/support.yml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (33)

GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
GitHub Check: testing-farm:fedora-rawhide-x86_64:cockpit
GitHub Check: testing-farm:fedora-41-x86_64:local
GitHub Check: testing-farm:fedora-42-x86_64:local
GitHub Check: testing-farm:fedora-43-x86_64:local
GitHub Check: testing-farm:fedora-rawhide-x86_64:local
GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
GitHub Check: checks (make -f Makefile docs-ci, 1.91.0, cargo)
GitHub Check: checks (make -f Makefile build-no-ipc, 1.91.0, cargo)
GitHub Check: checks (PROFILEDIR=debug make -f Makefile build-no-ipc, 1.91.0, cargo)
GitHub Check: checks (PROFILEDIR=debug make -f Makefile build, 1.91.0, cargo)
GitHub Check: checks_with_udev (RUST_LOG=stratisd=debug make -f Makefile test-loop-root, 1.91.0, cargo)
GitHub Check: checks (PROFILEDIR=debug make -f Makefile build-min, 1.91.0, cargo)
GitHub Check: checks (PROFILEDIR=debug make -f Makefile build-utils, 1.91.0, cargo)
GitHub Check: checks (make -f Makefile clippy, 1.91.0, clippy)
GitHub Check: checks_with_tang_should_fail (TANG_URL=localhost make -f Makefile test-clevis-loop-should-fail-ro...
GitHub Check: tests-with-testing-repo (master)
GitHub Check: pylint
GitHub Check: python-based-tests
GitHub Check: stratis-min-cli-checks
GitHub Check: stratis-cli-checks
GitHub Check: checks (make -f Makefile build-no-ipc, 1.91.0, cargo)
GitHub Check: checks (make -f Makefile test, 1.91.0, cargo)
GitHub Check: checks (make -f Makefile build, 1.91.0, cargo)
GitHub Check: checks (make -f Makefile build-min, 1.91.0, cargo)
GitHub Check: checks (make -f Makefile clippy, 1.91.0, clippy)
GitHub Check: checks_with_udev (RUST_LOG=stratisd=debug make -f Makefile test-loop-root, 1.91.0, cargo)

🔇 Additional comments (1)

.github/workflows/cargo.yml (1)

32-32: Container image upgrade looks correct.

The Fedora version bump from 41 to 42 is straightforward and aligns with the PR objective. The marker comment # CURRENT DEVELOPMENT ENVIRONMENT is helpful for future maintenance.

Please verify that all packages in the dnf install command (lines 35–49) are available and compatible in Fedora 42. Additionally, confirm that the CI pipeline successfully builds and runs tests with this base image.

A related observation: the PR also adds libatomic to the support workflow's dependencies. Ensure this is compatible with Fedora 42 and document whether this is a new requirement introduced by the upgrade.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

packit-as-a-service · 2025-10-23T17:10:08Z

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

sudo yum install -y dnf-plugins-core on RHEL 8
sudo dnf install -y dnf-plugins-core on Fedora
dnf copr enable packit/stratis-storage-stratisd-3928-copr_pull
And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

mulkieran · 2025-11-05T00:42:13Z

We may have a test infrastructure problem...

mulkieran · 2025-11-05T00:47:12Z

We have a weird hang on check with udev and checks with tang and the rawhide tests have begun failing on mkfs command. I suspect that the problem with the rawhide tests is caused by a an xfs update and it is completely unrelated to this PR. Not so sure about the checks w/ udev/tang, though.

mulkieran · 2025-12-01T15:05:01Z

Same problem as before.

packit-as-a-service · 2025-12-16T15:50:32Z

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

sudo dnf install -y 'dnf*-command(copr)'
dnf copr enable packit/stratis-storage-stratisd-3928-copr_pull
And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

mulkieran · 2025-12-16T17:37:16Z

testing farm is now completely backed up.

mulkieran · 2026-01-02T18:04:40Z

All testing farm tests have now passed!

mulkieran · 2026-01-02T18:06:28Z

But there are two remaining GitHub tests that are just timing out:

mulkieran · 2026-01-02T18:07:08Z

rebased.

Signed-off-by: the Mulhern <amulhern@amulhern.bos.csb>

mulkieran · 2026-01-02T23:15:20Z

rebased.

mulkieran · 2026-01-05T15:11:51Z

the encrypted start w/out cache test succeeded this time. I will re run it if possible. Info from the timeout tests:

 running 8 tests
test engine::strat_engine::backstore::backstore::v1::tests::clevis_loop_should_fail_test_both_initialize - should panic ... ok
test engine::strat_engine::backstore::backstore::v1::tests::clevis_loop_should_fail_test_initialize - should panic ... ok
context canceled
test engine::strat_engine::backstore::backstore::v2::tests::clevis_loop_should_fail_test_both_initialize - should panic ... 
Error: The operation was canceled.

running 73 tests
[2026-01-02T23:19:27Z DEBUG stratisd::engine::strat_engine::backstore::devices] Verifying device /dev/loop2 using blkid probe: superblock probe: None, number of partitions: None
[2026-01-02T23:19:27Z DEBUG stratisd::engine::strat_engine::backstore::devices] Verifying device /dev/loop1 using blkid probe: superblock probe: None, number of partitions: None
[2026-01-02T23:19:27Z DEBUG stratisd::engine::strat_engine::backstore::devices] Verifying device /dev/loop3 using blkid probe: superblock probe: None, number of partitions: None
[2026-01-02T23:19:27Z DEBUG stratisd::engine::strat_engine::backstore::devices] Verifying device /dev/loop0 using blkid probe: superblock probe: None, number of partitions: None
context canceled
test engine::strat_engine::backstore::backstore::v1::tests::loop_test_add_cache_devs ...

mulkieran self-assigned this Oct 23, 2025

mulkieran added this to 2025October Oct 23, 2025

mulkieran moved this to Pending in 2025October Oct 23, 2025

mulkieran force-pushed the issue_project_805 branch from 9cb5a2f to ae45183 Compare October 23, 2025 16:54

mulkieran force-pushed the issue_project_805 branch from ae45183 to 36fe3d6 Compare November 4, 2025 18:59

mulkieran marked this pull request as ready for review November 4, 2025 18:59

mulkieran moved this from Pending to In Review in 2025October Nov 4, 2025

mulkieran force-pushed the issue_project_805 branch from 36fe3d6 to 5e3662f Compare November 4, 2025 23:40

mulkieran removed this from 2025October Nov 17, 2025

mulkieran added this to 2025November Nov 17, 2025

mulkieran moved this to In Review in 2025November Nov 17, 2025

mulkieran moved this from In Review to In Progress in 2025November Nov 17, 2025

mulkieran added this to 2025December Dec 1, 2025

mulkieran removed this from 2025November Dec 1, 2025

mulkieran moved this to In Progress in 2025December Dec 1, 2025

mulkieran force-pushed the issue_project_805 branch from 5e3662f to 19dcc8f Compare December 16, 2025 15:34

mulkieran force-pushed the issue_project_805 branch from 19dcc8f to c333861 Compare January 2, 2026 18:06

mulkieran moved this from In Progress to In Review in 2025December Jan 2, 2026

mulkieran removed this from 2025December Jan 2, 2026

mulkieran added this to 2026January Jan 2, 2026

mulkieran moved this to In Review in 2026January Jan 2, 2026

Increase CURRENT DEVELOPMENT ENVIRONMENT to Fedora 42

6d40129

Signed-off-by: the Mulhern <amulhern@amulhern.bos.csb>

mulkieran force-pushed the issue_project_805 branch from b415648 to 6d40129 Compare January 2, 2026 23:15

mulkieran mentioned this pull request Jan 3, 2026

Investigate timeouts in two encryption related tests on GitHub on F42 stratis-storage/project#839

Open

Increase CURRENT DEVELOPMENT ENVIRONMENT to Fedora 42 #3928

Are you sure you want to change the base?

Increase CURRENT DEVELOPMENT ENVIRONMENT to Fedora 42 #3928

Uh oh!

Conversation

mulkieran commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Poem

Pre-merge checks and finishing touches

Uh oh!

packit-as-a-service bot commented Oct 23, 2025

Uh oh!

mulkieran commented Nov 5, 2025

Uh oh!

mulkieran commented Nov 5, 2025

Uh oh!

mulkieran commented Dec 1, 2025

Uh oh!

packit-as-a-service bot commented Dec 16, 2025

Uh oh!

mulkieran commented Dec 16, 2025

Uh oh!

mulkieran commented Jan 2, 2026

Uh oh!

mulkieran commented Jan 2, 2026

Uh oh!

mulkieran commented Jan 2, 2026

Uh oh!

mulkieran commented Jan 2, 2026

Uh oh!

mulkieran commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

mulkieran commented Oct 23, 2025 •

edited

Loading

coderabbitai bot commented Oct 23, 2025 •

edited

Loading

mulkieran commented Jan 5, 2026 •

edited

Loading