-
Notifications
You must be signed in to change notification settings - Fork 57
Additional zbus interfaces #3947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Additional zbus interfaces #3947
Conversation
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
|
First error can be fixed by completing all filesystem registration and de-registration: |
|
Total: down massively from last time. |
86cfdde to
9a73b88
Compare
9a73b88 to
43c0993
Compare
Previously, our engine took ownership of file descriptors passed into the engine by calling File::from_raw_fd. This change avoids a memory leak while also preventing File from running close on the file descriptor. This should avoid a double close when zbus later closes the file descriptor.
43c0993 to
a5a1f29
Compare
|
rebased. Dropped file descriptor duplication commit. |
This changes all of the returned ObjectPaths to owned variants and sending signals now acquires an immutable reference to the underlying interface object.
It appears that returning PoolUuid::default() will crash the D-Bus socket and stratisd will fail to receive any future D-Bus messages. Returning a String fixes the problem.
|
No apparent errors on key setting with the alternative fix, so we can go with that. |
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
a5a1f29 to
52abfad
Compare
|
rebased, a few compiler errors fixed. |
|
Ignore rawhide FTBFS, this is due to procfs update. |
|
stratis-cli checks improves again:
|
e034156 to
81d548f
Compare
|
Number of failures and errors increased for stratis-cli tests with blockdev deregister code: |
Do this when stopping or when destroying a pool Signed-off-by: mulhern <amulhern@redhat.com>
81d548f to
36a2e24
Compare
|
Back to |
No description provided.