Skip to content

Conversation

@mulkieran
Copy link
Member

No description provided.

@mulkieran mulkieran self-assigned this Dec 19, 2025
@mulkieran mulkieran moved this to In Progress in 2025December Dec 19, 2025
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/stratis-storage-stratisd-3947-copr_pull
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran
Copy link
Member Author

First error can be fixed by completing all filesystem registration and de-registration:

======================================================================
ERROR: test_cancel_revert_when_no_origin (integration.logical.test_cancel_revert.FsCancelRevertTestCase.test_cancel_revert_when_no_origin)
Cancelling a revert on a filesystem with no origin should fail.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.13/site-packages/dbus_python_client_gen/_invokers.py", line 123, in dbus_func
    return proxy_object.Set(
           ~~~~~~~~~~~~~~~~^
        interface_name,
        ^^^^^^^^^^^^^^^
    ...<3 lines>...
        timeout=timeout,
        ^^^^^^^^^^^^^^^^
    )
    ^
  File "/usr/lib64/python3.13/site-packages/dbus/proxies.py", line 141, in __call__
    return self._connection.call_blocking(self._named_service,
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
                                          self._object_path,
                                          ^^^^^^^^^^^^^^^^^^
    ...<3 lines>...
                                          args,
                                          ^^^^^
                                          **keywords)
                                          ^^^^^^^^^^^
  File "/usr/lib64/python3.13/site-packages/dbus/connection.py", line 634, in call_blocking
    reply_message = self.send_message_with_reply_and_block(
        message, timeout)
dbus.exceptions.DBusException: org.freedesktop.zbus.Error: Filesystem e75650eb-ec02-4735-b1ab-dca1233f2b72 has no origin, revert cannot be scheduled

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/__w/stratisd/stratisd/stratis-cli/src/stratis_cli/_main.py", line 51, in the_func
    namespace.func(namespace)
    ~~~~~~~~~~~~~~^^^^^^^^^^^
  File "/__w/stratisd/stratisd/stratis-cli/src/stratis_cli/_parser/_parser.py", line 151, in wrapped_func
    func(*args)
    ~~~~^^^^^^^
  File "/__w/stratisd/stratisd/stratis-cli/src/stratis_cli/_actions/_logical.py", line 406, in cancel_revert
    Filesystem.Properties.MergeScheduled.Set(get_object(fs_object_path), False)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/dbus_python_client_gen/_invokers.py", line 135, in dbus_func
    raise DPClientInvocationError(
        err_msg, interface_name, DPClientSetPropertyContext(name, arg)
    ) from err
dbus_python_client_gen._errors.DPClientInvocationError: Error while setting value of property "MergeScheduled" belonging to interface "org.storage.stratis3.filesystem.r9" to value "dbus.Boolean(False, variant_level=1)"

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/__w/stratisd/stratisd/stratis-cli/tests/integration/logical/test_cancel_revert.py", line 78, in test_cancel_revert_when_no_origin
    self.check_error(DPClientInvocationError, command_line, _ERROR)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/__w/stratisd/stratisd/stratis-cli/tests/integration/_misc.py", line 196, in check_error
    handle_error(exception)
    ~~~~~~~~~~~~^^^^^^^^^^^
  File "/__w/stratisd/stratisd/stratis-cli/src/stratis_cli/_error_reporting.py", line 413, in handle_error
    raise err
stratis_cli._errors.StratisCliActionError: Action selected by command-line arguments ['--propagate', 'filesystem', 'cancel-revert', 'pool', 'nofs'] which were parsed to Namespace(print_all_help=None, propagate=True, unhyphenated_uuids=False, func=<function add_subcommand.<locals>.wrap_func.<locals>.wrapped_func at 0x7f2af3a249a0>, pool_name='pool', snapshot_name='nofs') failed

@mulkieran
Copy link
Member Author

Total:

FAILED (failures=18, errors=41)

down massively from last time.

Previously, our engine took ownership of file descriptors passed into
the engine by calling File::from_raw_fd. This change avoids a memory
leak while also preventing File from running close on the
file descriptor. This should avoid a double close when zbus later closes
the file descriptor.
@mulkieran
Copy link
Member Author

rebased. Dropped file descriptor duplication commit.

This changes all of the returned ObjectPaths to owned variants and
sending signals now acquires an immutable reference to the underlying
interface object.
It appears that returning PoolUuid::default() will crash the D-Bus
socket and stratisd will fail to receive any future D-Bus messages.
Returning a String fixes the problem.
@mulkieran
Copy link
Member Author

No apparent errors on key setting with the alternative fix, so we can go with that.

Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran force-pushed the additional-zbus-interfaces branch from a5a1f29 to 52abfad Compare January 6, 2026 14:42
@mulkieran
Copy link
Member Author

rebased, a few compiler errors fixed.

@mulkieran
Copy link
Member Author

Ignore rawhide FTBFS, this is due to procfs update.

@mulkieran
Copy link
Member Author

stratis-cli checks improves again:

FAILED (failures=5, errors=5)

@mulkieran mulkieran force-pushed the additional-zbus-interfaces branch 2 times, most recently from e034156 to 81d548f Compare January 6, 2026 16:06
@mulkieran
Copy link
Member Author

Number of failures and errors increased for stratis-cli tests with blockdev deregister code: FAILED (failures=7, errors=24).

Do this when stopping or when destroying a pool

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran force-pushed the additional-zbus-interfaces branch from 81d548f to 36a2e24 Compare January 6, 2026 18:53
@mulkieran
Copy link
Member Author

Back to FAILED (failures=5, errors=5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants