Skip to content

bump buffer_sv2 patch#1302

Merged
plebhash merged 3 commits into
stratum-mining:mainfrom
plebhash:bump-buffer-major
Dec 18, 2024
Merged

bump buffer_sv2 patch#1302
plebhash merged 3 commits into
stratum-mining:mainfrom
plebhash:bump-buffer-major

Conversation

@plebhash
Copy link
Copy Markdown
Member

@plebhash plebhash commented Dec 18, 2024 •
edited
Loading

we need to bump buffer_sv2 PATCH version for two modifications introduced during milestone v1.2.0:

this PR bumps buffer_sv2 PATCH from 1.1.0 to 1.1.1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 18, 2024 •
edited
Loading

🐰 Bencher Report

Branchbump-buffer-major
Testbedsv2

🚨 3 Alerts

BenchmarkMeasure
Units		ViewBenchmark Result
(Result Δ%)		Upper Boundary
(Limit %)
client_sv2_mining_message_submit_standard_serialize_deserializeL2 Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		97.00
(+17.40%)		96.22
(100.81%)
client_sv2_open_channel_serializeL2 Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		49.00
(+37.06%)		46.80
(104.70%)
client_sv2_open_channel_serialize_deserializeL2 Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		91.00
(+21.12%)		88.14
(103.24%)
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2,171.00
(+2.98%)		2,225.62
(97.55%)		📈 view plot
🚷 view threshold		473.00
(-0.06%)		489.01
(96.73%)		📈 view plot
🚷 view threshold		731.00
(-0.62%)		758.01
(96.44%)		📈 view plot
🚷 view threshold		8.00
(+54.68%)		13.12
(60.97%)		📈 view plot
🚷 view threshold		40.00
(+3.96%)		41.56
(96.25%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8,326.00
(+1.31%)		8,374.99
(99.42%)		📈 view plot
🚷 view threshold		2,137.00
(-0.02%)		2,142.55
(99.74%)		📈 view plot
🚷 view threshold		3,151.00
(-0.28%)		3,170.99
(99.37%)		📈 view plot
🚷 view threshold		41.00
(+15.44%)		41.85
(97.97%)		📈 view plot
🚷 view threshold		142.00
(+1.82%)		143.76
(98.77%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6,395.00
(+1.55%)		6,440.71
(99.29%)		📈 view plot
🚷 view threshold		1,750.00
(-0.04%)		1,767.14
(99.03%)		📈 view plot
🚷 view threshold		2,545.00
(-0.29%)		2,575.78
(98.81%)		📈 view plot
🚷 view threshold		21.00
(+22.96%)		24.46
(85.84%)		📈 view plot
🚷 view threshold		107.00
(+2.34%)		108.53
(98.59%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14,870.00
(+0.99%)		14,941.79
(99.52%)		📈 view plot
🚷 view threshold		4,694.00
(-0.02%)		4,711.14
(99.64%)		📈 view plot
🚷 view threshold		6,740.00
(-0.25%)		6,786.24
(99.32%)		📈 view plot
🚷 view threshold		58.00
(+30.06%)		59.87
(96.88%)		📈 view plot
🚷 view threshold		224.00
(+1.23%)		226.66
(98.83%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27,880.00
(+1.11%)		27,977.95
(99.65%)		📈 view plot
🚷 view threshold		10,645.00
(+0.43%)		10,679.22
(99.68%)		📈 view plot
🚷 view threshold		15,495.00
(+0.44%)		15,561.92
(99.57%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		97.00
(+17.40%)		96.22
(100.81%)		📈 view plot
🚷 view threshold		340.00
(+1.42%)		342.37
(99.31%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4,523.00
(+3.08%)		4,548.40
(99.44%)		📈 view plot
🚷 view threshold		1,461.00
(-0.02%)		1,477.01
(98.92%)		📈 view plot
🚷 view threshold		2,153.00
(-0.35%)		2,183.69
(98.59%)		📈 view plot
🚷 view threshold		12.00
(+45.32%)		14.50
(82.77%)		📈 view plot
🚷 view threshold		66.00
(+5.67%)		67.01
(98.50%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14,170.00
(+1.08%)		14,198.62
(99.80%)		📈 view plot
🚷 view threshold		5,064.00
(-0.01%)		5,080.01
(99.68%)		📈 view plot
🚷 view threshold		7,310.00
(-0.22%)		7,351.59
(99.43%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		49.00
(+37.06%)		46.80
(104.70%)		📈 view plot
🚷 view threshold		189.00
(+1.56%)		191.20
(98.85%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22,916.00
(+1.04%)		22,980.96
(99.72%)		📈 view plot
🚷 view threshold		8,040.00
(+0.12%)		8,052.51
(99.84%)		📈 view plot
🚷 view threshold		11,681.00
(-0.01%)		11,710.48
(99.75%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		91.00
(+21.12%)		88.14
(103.24%)		📈 view plot
🚷 view threshold		308.00
(+1.49%)		310.77
(99.11%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4,753.00
(+1.41%)		4,786.09
(99.31%)		📈 view plot
🚷 view threshold		1,502.00
(-0.02%)		1,518.01
(98.95%)		📈 view plot
🚷 view threshold		2,273.00
(-0.22%)		2,299.52
(98.85%)		📈 view plot
🚷 view threshold		13.00
(+34.52%)		16.37
(79.40%)		📈 view plot
🚷 view threshold		69.00
(+2.32%)		70.05
(98.51%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16,294.00
(+0.91%)		16,305.21
(99.93%)		📈 view plot
🚷 view threshold		5,963.00
(-0.00%)		5,979.01
(99.73%)		📈 view plot
🚷 view threshold		8,649.00
(-0.17%)		8,691.56
(99.51%)		📈 view plot
🚷 view threshold		52.00
(+29.95%)		54.29
(95.78%)		📈 view plot
🚷 view threshold		211.00
(+1.39%)		211.88
(99.58%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35,854.00
(+0.78%)		35,882.02
(99.92%)		📈 view plot
🚷 view threshold		14,888.00
(+0.17%)		14,908.27
(99.86%)		📈 view plot
🚷 view threshold		21,864.00
(+0.12%)		21,906.40
(99.81%)		📈 view plot
🚷 view threshold		110.00
(+18.82%)		113.50
(96.92%)		📈 view plot
🚷 view threshold		384.00
(+1.23%)		385.10
(99.72%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 18, 2024 •
edited
Loading

🐰 Bencher Report

Branchbump-buffer-major
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		44.56
(+0.12%)		46.54
(95.75%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		75.73
(-3.83%)		105.23
(71.96%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.66
(+0.05%)		14.71
(99.70%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		260.59
(-1.98%)		293.01
(88.94%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		601.68
(-1.74%)		649.16
(92.69%)
client_sv2_open_channel📈 view plot
🚷 view threshold		165.30
(+0.28%)		175.25
(94.32%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		277.63
(-2.46%)		311.35
(89.17%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		379.44
(-1.11%)		411.30
(92.25%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		160.63
(+0.40%)		171.24
(93.80%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		505.67
(+6.81%)		560.89
(90.16%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		1,001.70
(+0.93%)		1,097.64
(91.26%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 18, 2024 •
edited
Loading

🐰 Bencher Report

Branchbump-buffer-major
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8,396.00
(-0.74%)		8,678.63
(96.74%)		📈 view plot
🚷 view threshold		3,671.00
(-1.73%)		3,863.92
(95.01%)		📈 view plot
🚷 view threshold		5,121.00
(-2.13%)		5,450.62
(93.95%)		📈 view plot
🚷 view threshold		11.00
(+39.54%)		15.45
(71.22%)		📈 view plot
🚷 view threshold		92.00
(+1.06%)		95.91
(95.92%)
get_submit📈 view plot
🚷 view threshold		95,302.00
(-0.09%)		95,745.63
(99.54%)		📈 view plot
🚷 view threshold		59,271.00
(-0.26%)		59,716.53
(99.25%)		📈 view plot
🚷 view threshold		85,087.00
(-0.31%)		85,831.95
(99.13%)		📈 view plot
🚷 view threshold		48.00
(+8.59%)		59.19
(81.09%)		📈 view plot
🚷 view threshold		285.00
(+1.60%)		290.50
(98.11%)
get_subscribe📈 view plot
🚷 view threshold		7,901.00
(-1.35%)		8,233.98
(95.96%)		📈 view plot
🚷 view threshold		2,766.00
(-2.01%)		2,942.45
(94.00%)		📈 view plot
🚷 view threshold		3,846.00
(-2.41%)		4,142.07
(92.85%)		📈 view plot
🚷 view threshold		13.00
(+9.11%)		19.66
(66.11%)		📈 view plot
🚷 view threshold		114.00
(-0.46%)		117.73
(96.83%)
serialize_authorize📈 view plot
🚷 view threshold		12,189.00
(-0.67%)		12,509.68
(97.44%)		📈 view plot
🚷 view threshold		5,248.00
(-1.14%)		5,428.69
(96.67%)		📈 view plot
🚷 view threshold		7,289.00
(-1.45%)		7,605.90
(95.83%)		📈 view plot
🚷 view threshold		14.00
(+44.28%)		18.32
(76.41%)		📈 view plot
🚷 view threshold		138.00
(+0.08%)		142.11
(97.11%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24,626.00
(-0.34%)		25,181.38
(97.79%)		📈 view plot
🚷 view threshold		9,794.00
(-0.78%)		10,029.31
(97.65%)		📈 view plot
🚷 view threshold		13,796.00
(-0.97%)		14,196.85
(97.18%)		📈 view plot
🚷 view threshold		38.00
(+7.83%)		45.33
(83.83%)		📈 view plot
🚷 view threshold		304.00
(+0.35%)		313.43
(96.99%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30,239.00
(-0.30%)		30,708.39
(98.47%)		📈 view plot
🚷 view threshold		11,997.00
(-0.55%)		12,199.67
(98.34%)		📈 view plot
🚷 view threshold		16,964.00
(-0.68%)		17,308.52
(98.01%)		📈 view plot
🚷 view threshold		58.00
(+4.42%)		66.97
(86.60%)		📈 view plot
🚷 view threshold		371.00
(+0.09%)		379.36
(97.80%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126,464.00
(-0.01%)		126,775.70
(99.75%)		📈 view plot
🚷 view threshold		73,117.00
(-0.20%)		73,527.31
(99.44%)		📈 view plot
🚷 view threshold		104,759.00
(-0.26%)		105,493.90
(99.30%)		📈 view plot
🚷 view threshold		113.00
(+6.78%)		124.29
(90.92%)		📈 view plot
🚷 view threshold		604.00
(+1.08%)		607.85
(99.37%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27,849.00
(-0.17%)		28,444.39
(97.91%)		📈 view plot
🚷 view threshold		9,585.00
(-0.57%)		9,755.87
(98.25%)		📈 view plot
🚷 view threshold		13,529.00
(-0.74%)		13,830.36
(97.82%)		📈 view plot
🚷 view threshold		71.00
(+11.24%)		76.59
(92.71%)		📈 view plot
🚷 view threshold		399.00
(+0.12%)		411.94
(96.86%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115,181.00
(-0.06%)		115,727.07
(99.53%)		📈 view plot
🚷 view threshold		67,894.00
(-0.27%)		68,422.50
(99.23%)		📈 view plot
🚷 view threshold		97,356.00
(-0.34%)		98,290.12
(99.05%)		📈 view plot
🚷 view threshold		72.00
(+12.83%)		84.25
(85.46%)		📈 view plot
🚷 view threshold		499.00
(+1.27%)		501.51
(99.50%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23,246.00
(-0.28%)		23,853.39
(97.45%)		📈 view plot
🚷 view threshold		8,137.00
(-0.70%)		8,312.81
(97.89%)		📈 view plot
🚷 view threshold		11,431.00
(-0.93%)		11,739.51
(97.37%)		📈 view plot
🚷 view threshold		46.00
(+20.85%)		48.81
(94.24%)		📈 view plot
🚷 view threshold		331.00
(+0.01%)		343.73
(96.30%)
serialize_submit📈 view plot
🚷 view threshold		99,763.00
(-0.05%)		100,185.91
(99.58%)		📈 view plot
🚷 view threshold		61,333.00
(-0.23%)		61,743.08
(99.34%)		📈 view plot
🚷 view threshold		87,943.00
(-0.29%)		88,660.25
(99.19%)		📈 view plot
🚷 view threshold		54.00
(+14.82%)		64.93
(83.17%)		📈 view plot
🚷 view threshold		330.00
(+1.45%)		335.76
(98.29%)
serialize_subscribe📈 view plot
🚷 view threshold		11,392.00
(-0.13%)		11,611.51
(98.11%)		📈 view plot
🚷 view threshold		4,119.00
(-1.26%)		4,282.81
(96.18%)		📈 view plot
🚷 view threshold		5,702.00
(-1.66%)		5,995.05
(95.11%)		📈 view plot
🚷 view threshold		18.00
(+36.41%)		22.31
(80.68%)		📈 view plot
🚷 view threshold		160.00
(+1.04%)		163.54
(97.83%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 18, 2024 •
edited
Loading

🐰 Bencher Report

Branchbump-buffer-major
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,577.20
(-0.70%)		7,061.01
(93.15%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,371.00
(-1.41%)		8,025.58
(91.84%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		8,066.70
(-0.94%)		9,397.61
(85.84%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		884.86
(+2.27%)		938.92
(94.24%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		684.44
(+1.76%)		716.57
(95.52%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		251.23
(+0.91%)		271.27
(92.61%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		158.30
(+0.66%)		166.62
(95.01%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,414.80
(+0.00%)		7,007.92
(91.54%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		281.97
(+0.04%)		318.33
(88.58%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		736.90
(+1.40%)		777.54
(94.77%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		597.94
(+1.81%)		616.10
(97.05%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		202.90
(-1.69%)		224.52
(90.37%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.29%. Comparing base (da06218) to head (a3bf766).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1302   +/-   ##
=======================================
  Coverage   19.29%   19.29%           
=======================================
  Files         164      164           
  Lines       10852    10852           
=======================================
  Hits         2094     2094           
  Misses       8758     8758
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.65% <ø> (ø)
binary_sv2-coverage 5.48% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.29% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.51% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.35% <ø> (ø)
pool_sv2-coverage 1.38% <ø> (ø)
protocols 24.72% <ø> (ø)
roles 6.54% <ø> (ø)
roles_logic_sv2-coverage 8.08% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@plebhash plebhash mentioned this pull request Dec 18, 2024
Closed
Shourya742
Shourya742 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Shourya742 Shourya742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@plebhash plebhash changed the title bump buffer_sv2 major as a follow up to #1300 bump buffer_sv2 patch Dec 18, 2024
@plebhash plebhash merged commit 789bb5e into stratum-mining:main Dec 18, 2024
@plebhash plebhash deleted the bump-buffer-major branch December 18, 2024 13:24
@plebhash plebhash added the version-bump version bump for release management label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitGab19 GitGab19 GitGab19 approved these changes

@Shourya742 Shourya742 Shourya742 approved these changes

Assignees

No one assigned

Labels

version-bump version bump for release management

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@plebhash @GitGab19 @Shourya742