Skip to content

Remove binary codec sv2 #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plebhash merged 7 commits into from
Oct 20, 2025
Merged

Remove binary codec sv2 #1952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
df29c8f
reorganise binary-sv2 deprecate binary-codec-sv2 and move its content…
Shourya742 Oct 17, 2025
dbe92e6
update all workflows file
Shourya742 Oct 17, 2025
c88a77f
control the ripple effect
Shourya742 Oct 17, 2025
9ff3885
update the lock files
Shourya742 Oct 17, 2025
fb0ea75
bump the binary
Shourya742 Oct 17, 2025
cdfc4a5
Update PATCH on all crates dependent on binary_sv2
Shourya742 Oct 17, 2025
b7802fd
update integrationt test lock file
Shourya742 Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/coverage-protocols.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,6 @@ jobs:
file: ./protocols/target/tarpaulin-reports/cobertura.xml
flags: protocols
token: ${{ secrets.CODECOV_TOKEN }}

- name: Upload binary_codec_sv2-coverage to codecov.io
uses: codecov/codecov-action@v4
with:
directory: ./protocols/target/tarpaulin-reports/codec-coverage
file: ./protocols/target/tarpaulin-reports/codec-coverage/cobertura.xml
flags: binary_codec_sv2-coverage
token: ${{ secrets.CODECOV_TOKEN }}

- name: Upload binary_sv2-coverage to codecov.io
uses: codecov/codecov-action@v4
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,6 @@ jobs:
cd protocols/v2/binary-sv2/derive_codec
cargo doc

- name: Rust Docs crate binary_sv2 codec
run: |
cd protocols/v2/binary-sv2/codec
cargo doc --features with_buffer_pool

- name: Rust Docs crate binary_sv2
run: |
cd protocols/v2/binary-sv2
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/release-libs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,6 @@ jobs:
run: |
./scripts/release-libs.sh protocols/v2/noise-sv2

# binary_sv2 (depends on buffer_sv2)
- name: Publish crate binary_sv2 codec
run: |
./scripts/release-libs.sh protocols/v2/binary-sv2/codec

- name: Publish crate binary_sv2 derive_codec
run: |
./scripts/release-libs.sh protocols/v2/binary-sv2/derive_codec
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/semver-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@ jobs:
working-directory: utils/buffer
run: cargo semver-checks

- name: Run semver checks for protocols/v2/binary-sv2/codec
working-directory: protocols/v2/binary-sv2/codec
run: cargo semver-checks

- name: Run semver checks for protocols/v2/binary-sv2
working-directory: protocols/v2/binary-sv2
run: cargo semver-checks
Expand Down
2 changes: 1 addition & 1 deletion examples/ping-pong-encrypted/src/messages.rs
View file
Open in desktop
Comment thread
GitGab19 marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use crate::error::Error;
use stratum_apps::stratum_core::binary_sv2::{
self as binary_sv2, binary_codec_sv2,
self as binary_sv2,
decodable::{DecodableField, FieldMarker},
Deserialize, Serialize,
};
Expand Down
2 changes: 1 addition & 1 deletion examples/ping-pong/src/messages.rs
View file
Open in desktop
Comment thread
GitGab19 marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use crate::error::Error;
use stratum_apps::stratum_core::binary_sv2::{binary_codec_sv2, Deserialize, Serialize};
use stratum_apps::stratum_core::binary_sv2::{self, Deserialize, Serialize};

use rand::Rng;

Expand Down
1 change: 0 additions & 1 deletion protocols/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ resolver="2"

members = [
"v1",
"v2/binary-sv2/codec",
"v2/binary-sv2/derive_codec",
"v2/binary-sv2",
"v2/noise-sv2",
Expand Down
Loading
Loading