make roles use bitcoin from stratum-apps::stratum-core#1963
Merged
Conversation
GitGab19
force-pushed
the
fix-bitcoin-import
branch
from
87a02e9 to
dde9d7e
Compare
GitGab19
changed the title
bitcoin from stratum-appsbitcoin from stratum-apps::stratum-core
plebhash
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #1950 some roles have been modified to import
bitcoin, while we always had it re-exported by the single hubstratum-core.The exceptions are JDS and mining-device, just because they have to be properly refactored to be using the new crates.
This PR removes the useless
bitcoinimport from all the other roles.