update code coverage workflow#1979
Merged
GitGab19 merged 2 commits intoOct 28, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1979 +/- ##
==========================================
+ Coverage 25.26% 30.40% +5.14%
==========================================
Files 141 90 -51
Lines 7181 5647 -1534
==========================================
- Hits 1814 1717 -97
+ Misses 5367 3930 -1437
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
409a8ca to
3dcc176
Compare
plebhash
approved these changes
Oct 28, 2025
GitGab19
reviewed
Oct 28, 2025
Member
GitGab19
left a comment
There was a problem hiding this comment.
We are missing buffer_sv2 and stratum-translation in both places.
GitGab19
reviewed
Oct 28, 2025
8cb9004 to
e4aa3b1
Compare
GitGab19
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1978
as follow-up of #1860
this removes
roles_logic_sv2from the code coverage script, and adapt where needed