Skip to content

update code coverage workflow#1979

Merged
GitGab19 merged 2 commits into
stratum-mining:mainfrom
lucasbalieiro:remove-deprecated-coverage
Oct 28, 2025
Merged

update code coverage workflow#1979
GitGab19 merged 2 commits into
stratum-mining:mainfrom
lucasbalieiro:remove-deprecated-coverage

Conversation

@lucasbalieiro
Copy link
Copy Markdown
Collaborator

@lucasbalieiro lucasbalieiro commented Oct 28, 2025

closes #1978
as follow-up of #1860

this removes roles_logic_sv2 from the code coverage script, and adapt where needed

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.40%. Comparing base (0b7f825) to head (8cb9004).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1979      +/-   ##
==========================================
+ Coverage   25.26%   30.40%   +5.14%     
==========================================
  Files         141       90      -51     
  Lines        7181     5647    -1534     
==========================================
- Hits         1814     1717      -97     
+ Misses       5367     3930    -1437     
Flag Coverage Δ
binary_sv2-coverage 6.54% <ø> (-1.09%) ⬇️
buffer_sv2-coverage 2.38% <ø> (?)
channels_sv2-coverage 16.60% <ø> (-2.56%) ⬇️
codec_sv2-coverage 0.18% <ø> (+0.15%) ⬆️
common_messages_sv2-coverage 0.16% <ø> (-0.03%) ⬇️
framing_sv2-coverage 0.35% <ø> (-0.06%) ⬇️
handler_sv2-coverage 0.00% <ø> (?)
jd_client-coverage ?
jd_server-coverage ?
job_declaration_sv2-coverage 0.00% <ø> (ø)
mining-coverage 2.95% <ø> (-0.48%) ⬇️
mining_device-coverage ?
noise_sv2-coverage 5.56% <ø> (-0.94%) ⬇️
parsers_sv2-coverage 1.74% <ø> (-0.27%) ⬇️
pool_sv2-coverage ?
protocols 30.40% <ø> (-1.79%) ⬇️
roles ?
stratum-apps-coverage ?
stratum_translation-coverage 1.99% <ø> (?)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage ?
v1-coverage ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lucasbalieiro lucasbalieiro force-pushed the remove-deprecated-coverage branch from 409a8ca to 3dcc176 Compare October 28, 2025 14:51
@lucasbalieiro lucasbalieiro marked this pull request as ready for review October 28, 2025 14:51
Copy link
Copy Markdown
Member

@GitGab19 GitGab19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing buffer_sv2 and stratum-translation in both places.

@lucasbalieiro lucasbalieiro changed the title remove deprecated coverage from CI update code coverage workflow Oct 28, 2025
Comment thread .github/workflows/coverage-protocols.yaml Outdated
@lucasbalieiro lucasbalieiro force-pushed the remove-deprecated-coverage branch from 8cb9004 to e4aa3b1 Compare October 28, 2025 15:42
@GitGab19 GitGab19 merged commit 517c5f2 into stratum-mining:main Oct 28, 2025
12 checks passed
@lucasbalieiro lucasbalieiro deleted the remove-deprecated-coverage branch October 28, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

coverage_protocols.sh has references of roles_logic_sv2

3 participants