Skip to content

Optimize Extranonce cloning in hot path (Fixes #2076) #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
therohityadav wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

Optimize Extranonce cloning in hot path (Fixes #2076) #2079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sv2/channels-sv2/src/server/extended.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,8 +677,8 @@ where

let extranonce_prefix = job.get_extranonce_prefix();
let mut full_extranonce = vec![];
full_extranonce.extend(extranonce_prefix.clone());
full_extranonce.extend(share.extranonce.inner_as_ref());
full_extranonce.extend_from_slice(extranonce_prefix);
full_extranonce.extend_from_slice(share.extranonce.as_ref());

// calculate the merkle root from:
// - job coinbase_tx_prefix
Expand Down
6 changes: 6 additions & 0 deletions sv2/subprotocols/mining/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,12 @@ pub struct Extranonce {
extranonce: alloc::vec::Vec<u8>,
}

impl AsRef<[u8]> for Extranonce {
fn as_ref(&self) -> &[u8] {
&self.extranonce
}
}

// this function converts a U256 type in little endian to Extranonce type
impl<'a> From<U256<'a>> for Extranonce {
fn from(v: U256<'a>) -> Self {
Expand Down
Loading