test: extract reusable SV2 Connman tester#105
Open
enirox001 wants to merge 1 commit into
Open
Conversation
Author
Collaborator
Move ConnTester out of sv2_connman_tests.cpp into a shared test helper so future SV2 Connman tests can reuse the mock DynSock client setup without duplicating it.
e9f149d to
d435274
Compare
Author
Thanks for catching that. i have properly restored the comments. Also recheked the diff with git show --color-moved=dimmed-zebra --color-moved-ws=ignore-space-change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Moves
ConnTesterout ofsv2_connman_tests.cppinto a reusable test helper.This keeps the existing SV2 Connman test behavior unchanged while making the mock DynSock client setup available to future tests.
Tested with
Closes #78