Skip to content

test: extract reusable SV2 Connman tester#105

Open
enirox001 wants to merge 1 commit into
stratum-mining:masterfrom
enirox001:test/reuse-sv2-connman-tester
Open

test: extract reusable SV2 Connman tester#105
enirox001 wants to merge 1 commit into
stratum-mining:masterfrom
enirox001:test/reuse-sv2-connman-tester

Conversation

@enirox001
Copy link
Copy Markdown

Moves ConnTester out of sv2_connman_tests.cpp into a reusable test helper.

This keeps the existing SV2 Connman test behavior unchanged while making the mock DynSock client setup available to future tests.

Tested with

  cmake --build build --target test_sv2
  build/bin/test_sv2 --run_test=sv2_connman_tests
  --catch_system_error=no --log_level=test_suite

Closes #78

@enirox001 enirox001 changed the title test: Extract reusable SV2 Connman tester test: extract reusable SV2 Connman tester May 12, 2026
@enirox001
Copy link
Copy Markdown
Author

@Sjors this is based on your suggestion in #78, would appreciate a review when you have time.

@Sjors
Copy link
Copy Markdown
Collaborator

Sjors commented May 12, 2026

Concept ACK

When looking at the commit with git show --color-moved=dimmed-zebra --color-moved-ws=ignore-space-change I noticed some comments disappeared:

Scherm­afbeelding 2026-05-12 om 09 13 59

(LLM's have an annoying habit of doing that, so it's always good to inspect the diff with dimmed-zebra)

Move ConnTester out of sv2_connman_tests.cpp into a shared test helper so future SV2 Connman tests can reuse the mock DynSock client setup without duplicating it.
@enirox001 enirox001 force-pushed the test/reuse-sv2-connman-tester branch from e9f149d to d435274 Compare May 12, 2026 08:09
@enirox001
Copy link
Copy Markdown
Author

When looking at the commit with git show --color-moved=dimmed-zebra --color-moved-ws=ignore-space-change I noticed some comments disappeared

Thanks for catching that. i have properly restored the comments. Also recheked the diff with

  git show --color-moved=dimmed-zebra --color-moved-ws=ignore-space-change 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: add MockSv2Client for connection manager testing

2 participants