Add persistence to shares' stats#145
Merged
Merged
Conversation
GitGab19
force-pushed
the
add-persistence-to-shares
branch
from
474dc19 to
e2f3eff
Compare
Member
Author
|
In order to test this, you can simply connect to SRI SOLO pool, connect a cpu-miner, wait for some shares, and then kill the cpu-miner. cc @pavlenex |
Member
|
@lucasbalieiro can you have a look? |
GitGab19
force-pushed
the
add-persistence-to-shares
branch
from
e2f3eff to
4b65088
Compare
lucasbalieiro
approved these changes
May 6, 2026
Collaborator
lucasbalieiro
left a comment
lucasbalieiro
left a comment
There was a problem hiding this comment.
tACK 4b65088 with a superficial look at code.
Seems good enough. The other things that are in my head I can check after the release, since they are not blockers.
Member
Author
|
@lucasbalieiro can you open a tracker issue with these points you already have in mind? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds persistence to shares' stats: shares submitted and shares rejected (with the eventual rejection_reason) are now persistent in the same way we are already persisting best_difficulty and hashrate stats.
Closes #141