map types from openapi.json#150
Open
lucasbalieiro wants to merge 2 commits into
Open
Conversation
GitGab19
reviewed
May 12, 2026
Member
GitGab19
left a comment
GitGab19
left a comment
There was a problem hiding this comment.
I haven't tested anything yet, but I have some questions in the meantime.
| <InfoItem | ||
| label="Shares Acknowledged" | ||
| value={formatNumber(channel.shares_acknowledged)} | ||
| value={formatNumber('shares_acknowledged' in channel ? channel.shares_acknowledged : (channel as ExtendedChannelInfo | StandardChannelInfo).shares_accepted)} |
Member
There was a problem hiding this comment.
Why this change? Why do we have : (channel as ExtendedChannelInfo | StandardChannelInfo).shares_accepted?
| </TableCell> | ||
| <TableCell className="text-right font-mono font-medium"> | ||
| {formatHashrate(channel.nominal_hashrate)} | ||
| {formatHashrate(channel.nominal_hashrate ?? null)} |
Comment on lines
-409
to
+412
| channel_id: client.channel_id, | ||
| channel_id: client.channel_id ?? null, | ||
| channel_type: 'sv1' as ChannelType, | ||
| user_identity: client.user_identity, | ||
| estimated_hashrate: client.hashrate, | ||
| estimated_hashrate: client.hashrate ?? null, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #135.
this PR does not introduce any UI changes, since it is purely a refactor.
The main goal of testing here is to ensure that nothing was broken during the refactoring process. From my local tests, everything appears to be working correctly.