Fix: re-raise original docker exception in Sandbox.start error handlers - #75
Open
laohuan12138 wants to merge 1 commit into
Open
Fix: re-raise original docker exception in Sandbox.start error handlers#75laohuan12138 wants to merge 1 commit into
laohuan12138 wants to merge 1 commit into
Conversation
Collaborator
|
Just saw you PR. Gonna check this out to try and reproduce the error ! thank you @laohuan12138 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74
Summary
Sandbox.start()re-raised docker errors by constructing a new exception without a message:docker.errors.ImageNotFound/NotFoundinheritAPIError, whose__init__requiresmessage. The no-arg construction raisesTypeError: APIError.__init__() missing 1 required positional argument: 'message', masking the real error — e.g. whenxoxruns/sandboxed_kaliis missing locally, the user sees this TypeError instead ofImageNotFound.Change
Re-raise the original exception in both handlers:
Verification
TypeError: APIError.__init__() missing 1 required positional argument: 'message'reproduced with docker SDK 7.1.0 (both with real SDK and the exact class hierarchy).docker.errors.ImageNotFoundpropagates with its explanation intact.Note: full
pytestsuite not run here (dependencies not installed in this environment); the change is limited to the two exception-handler lines and does not alter normal flow.