Repository navigation
use the sfreleaser actions, publish the release, skip chain builds - #94
Conversation
Merging this PR will release reth-v2.9.0-fh3.1-not-a-real-version-alpha.2
Release notesTests the release made by sfreleaser, no Firehose changes. |
maoueh
left a comment
There was a problem hiding this comment.
Don't you need to update sf-release.yml to prevent doing the full release?
|
|
||
| - name: Detect version | ||
| id: detect | ||
| uses: streamingfast/actions/sfreleaser/detect@v1 |
There was a problem hiding this comment.
Ok nice, does it share the sfreleaser installation? We still have a way to override right?
There was a problem hiding this comment.
yeah detect installs it once on PATH and prepare/publish reuse it in the same job
We can override with version: on detect (pinned to v0.17.1-rc.9 here until v0.18.0 is out, then it defaults to latest)
| with: | ||
| version: ${{ steps.detect.outputs.version }} | ||
| variant: ${{ steps.detect.outputs.variant }} | ||
| build-workflow: sf-release.yml |
There was a problem hiding this comment.
Ok so we need to kick in still the Docker build
| id: detect | ||
| uses: streamingfast/actions/sfreleaser/detect@v1 | ||
| with: | ||
| version: v0.17.1-rc.9 |
There was a problem hiding this comment.
Attribute version is confusing, should be sfreleaser-version: instead.
Also, it should not be there, action should pull latest, just wanted to know earlier if it had a way to override
There was a problem hiding this comment.
Renamed to sfreleaser-version and removed the pin, it pulls latest (needs a stable sfreleaser release, will do once Im sure)
| ref: ${{ github.head_ref }} | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Detect version |
There was a problem hiding this comment.
Detect version is confusing, should something more like Detect is release PR or anything along that line, Detect version seems like a version extraction action.
There was a problem hiding this comment.
Renamed to "Detect release PR"
Switches the release workflows to the shared
streamingfast/actionssfreleaser actions (renameddraft-release.yml/publish-release.yml): the PR drafts the release, merge publishes it, andsf-release.ymlattaches the binary; adds a test entryreth-v2.9.0-fh3.1-not-a-real-version-alpha.2.