Skip to content

use the sfreleaser actions, publish the release, skip chain builds - #94

Merged
UlysseCorbeil merged 6 commits into
release/reth-2.xfrom
feature/release-variant
Nov 11, 2026
Merged

UlysseCorbeil merged 6 commits into
release/reth-2.xfrom
feature/release-variant

Conversation

@UlysseCorbeil

Copy link
Copy Markdown

Switches the release workflows to the shared streamingfast/actions sfreleaser actions (renamed draft-release.yml / publish-release.yml): the PR drafts the release, merge publishes it, and sf-release.yml attaches the binary; adds a test entry reth-v2.9.0-fh3.1-not-a-real-version-alpha.2.

@UlysseCorbeil
UlysseCorbeil marked this pull request as draft November 10, 2026 18:57
@dfuse-bot
dfuse-bot requested a review from maoueh November 10, 2026 18:57
@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Merging this PR will release reth-v2.9.0-fh3.1-not-a-real-version-alpha.2

Release notes

Tests the release made by sfreleaser, no Firehose changes.

@UlysseCorbeil
UlysseCorbeil marked this pull request as ready for review November 10, 2026 20:04

@maoueh maoueh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to update sf-release.yml to prevent doing the full release?

Comment thread .github/workflows/sf-draft-release.yml Resolved

- name: Detect version
id: detect
uses: streamingfast/actions/sfreleaser/detect@v1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok nice, does it share the sfreleaser installation? We still have a way to override right?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah detect installs it once on PATH and prepare/publish reuse it in the same job
We can override with version: on detect (pinned to v0.17.1-rc.9 here until v0.18.0 is out, then it defaults to latest)

with:
version: ${{ steps.detect.outputs.version }}
variant: ${{ steps.detect.outputs.variant }}
build-workflow: sf-release.yml

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so we need to kick in still the Docker build

Comment thread .github/workflows/sf-draft-release.yml Outdated
id: detect
uses: streamingfast/actions/sfreleaser/detect@v1
with:
version: v0.17.1-rc.9

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attribute version is confusing, should be sfreleaser-version: instead.

Also, it should not be there, action should pull latest, just wanted to know earlier if it had a way to override

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to sfreleaser-version and removed the pin, it pulls latest (needs a stable sfreleaser release, will do once Im sure)

Comment thread .github/workflows/sf-draft-release.yml Outdated
ref: ${{ github.head_ref }}
fetch-depth: 0

- name: Detect version

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detect version is confusing, should something more like Detect is release PR or anything along that line, Detect version seems like a version extraction action.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to "Detect release PR"

Comment thread .sfreleaser Resolved
@UlysseCorbeil
UlysseCorbeil merged commit ec3ed3a into release/reth-2.x Nov 11, 2026
4 checks passed
@UlysseCorbeil
UlysseCorbeil deleted the feature/release-variant branch November 11, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants