Repository navigation
Bump reth to v2.11.0 - #95
Merged
Merged
Conversation
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Make DNS entry parsing more consistent and extend coverage for edge cases.
…z#28312) Checks for cancellation between calls in `eth_simulateV1`, as `eth_callMany` and the trace methods already do since paradigmxyz#27462.
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
…8307) Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
…gmxyz#28254) Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
…d space (paradigmxyz#28414) Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
…xyz#28424) Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
…8423) Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
Co-authored-by: Soubhik Singha Mahapatra <soubhiksmp2004@gmail.com> Co-authored-by: Ravan Mammadov <95362051+Ravan002@users.noreply.github.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com>
# Conflicts: # Cargo.lock # Cargo.toml # crates/engine/tree/Cargo.toml # crates/evm/evm/src/execute.rs # docs/vocs/bun.lock # docs/vocs/package.json # docs/vocs/vocs.config.ts
Call inputs are read from the caller's memory and the initial call depth moved from Version to Evm.
evm2 runs the EIP-4788 system call before EIP-2935 and opens the root frame of a transaction that runs out of gas in its runtime gas phase.
evm2 narrowed InstrStop::is_revert to the REVERT opcode. Insufficient balance, call depth and nonce overflow failures return their gas, now is_frame_revert.
Merging this PR will release reth-v2.11.0-fh3.1
Release notesChanged
|
Our only evm2 patch is upstream now, so the fork had the same tree as alloy-rs/evm2@66687c18.
|
@maoueh FYI: |
sduchesneau
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges upstream reth v2.11.0 into
release/reth-2.x. Merging this PR releasesreth-v2.11.0-fh3.1(the release workflow tags the merge commit from the CHANGELOG heading).What changed
Cargo.toml(version, workspace members, evm2[patch]),crates/engine/tree/Cargo.toml,crates/evm/evm/src/execute.rs(ourset_inspect_system_callsnext to upstream's newwith_inspector/take_inspector),Cargo.lock(upstream's, plus our entries), anddocs/vocs(upstream's). Upstream dropped theinkwellpatch, and so does this PR.streamingfast/evm2fork. Our only evm2 patch, opt-in inspection of system calls, went upstream in feat(evm): add opt-in inspection of system calls alloy-rs/evm2#888, so the fork had the same tree as upstream66687c18. The evm2[patch]block and the evm2 entries inCargo.lockare now identical to upstream reth v2.11.0's.MessageInput::as_bytes),initial_call_depthmoved fromVersiontoEvm, andBalWorkerErrorusesAnyError. The Firehose BAL tests and bench useAddress::from_raw_public_keyfor secp256k1 0.33. The new upstream e2e testexecutor_replaygets theFirehoseLiveHooksimpl every engine EVM config needs.InstrStop::is_revert()to theREVERTopcode. A call that fails before running (insufficient balance, call depth, nonce overflow) was then traced as consuming its whole gas limit instead of 0, on every fork. The inspector usesis_frame_revert()now, and a regression test covers it. Battlefield caught it.Effect on the Firehose block
alloy-hardforksstays at 0.4.11. Glamsterdam (Amsterdam) is still unscheduled on mainnet and Hoodi, and it has been active on Sepolia since block 11856337.ACTIVATIONS.mdis refreshed.fh3.1.Firehose bug patterns
par_iter().collect()keeps the order. It never calls the tracer. The BAL parallel path is unchanged apart from its error type. The new RPC replay through the block executor (feat(rpc): replay block transactions through the block executor paradigmxyz/reth#28266) uses the inner block executor factory;FirehoseEvmConfigonly wrapsbatch_executor, so RPC replays never reach the tracer. JIT stays refused while tracing.FirehoseBlockExecutorstill holds the block until the next block orinto_state(). Upstream adds no post-execution check after that point.InstrStopgainedReload, which no frame reports.Open questions
release/reth-2.xisreth-v2.9.0-fh3.1-not-a-real-version-alpha, a test of the release workflow. Applying the rule to it literally would givereth-v2.11.0-fh3.1-not-a-real-version-alpha. This PR usesreth-v2.11.0-fh3.1, following the last real releasereth-v2.10.0-fh3.1.crates/firehose-testschanged semantically (the orders described above). Please confirm.reth-dev'sdeploys/contract_fail_code_copysnapshot needs updating for the Amsterdam ordinal swap once this ships.sf/reth; that row no longer applies, since this release uses upstream evm2. evm-firehose-tracer-rs stays pinned atd35edd15, a commit onmain, until firehose-tracer 5.8.0 ships.Test Execution Summary
Build Status
cargo check --workspace --all-targets(reth,bump/reth-2.11.0atf557f816d): PASSEDcargo build --release --bin reth: PASSEDLLVM 23 (needed by
evm2-jitthroughllvm-sys231) was installed with the repository's own.github/scripts/install_llvm_ubuntu.sh 23, because the build image only ships LLVM 14 and 15.Unit Tests
cargo test -p reth-firehosecall_failed_on_insufficient_balance_consumes_no_gascargo test -p reth-firehose-testscargo test -p reth-engine-tree --lib --testsfirehose_live_tracing,firehose_live_tracing_amsterdam,firehose_live_tracing_prewarm_reusecargo test -p reth-evm -p reth-evm-ethereum --lib --testscargo test -p reth-firehose -p reth-firehose-testsat961bf9b5b(upstream evm2)streamingfast/evm2fork, whose tree is byte-identical to upstream66687c18Golden file changes (semantic, need a reviewer's OK)
Four
crates/firehose-testsAmsterdam goldens changed. Each change was checked to be only a reordering:amsterdam_slot_number,amsterdam_block_access_list,amsterdam_builder_execution_requests,amsterdam_create_runtime_out_of_gas: the two pre-block system calls swap places. evm2's block executor, which reth v2.11.0 now runs Ethereum blocks on, calls EIP-4788 (beacon roots) before EIP-2935 (block hash history). reth v2.10.0 called them the other way round. go-ethereum uses the new order. Same calls, same content; only their order and their ordinals change. Transactions are unchanged.amsterdam_create_runtime_out_of_gasonly: the rootCREATEcall now begins (ordinal 7) before the sender's nonce change (ordinal 8); it was the reverse. evm2 now fires the depth-0 frame hooks for a transaction that runs out of gas in its runtime gas phase, as go-ethereum'shaltTopFramedoes, so the tracer no longer synthesizes that root call. Status, gas and failure reason are unchanged.Integration Tests
Battlefield Tests
reth-devnet; onreth-dev, 1 expected diff (snapshot needs updating, see below)reth-dev(Amsterdam from genesis, as on Sepolia): 93 passing, 1 failing, 43 pending.Compare blockspassed.Deploys / Contract fail not enough gas after code_copy(deploys/contract_fail_code_copy): the rootCREATEbeginOrdinal3 → 2 and the sender nonce change ordinal 2 → 3. This is the same evm2 change as golden change 2 above. It is an expected diff: every other chain's snapshot of this test, geth included, puts the call's begin before the nonce change. Thereth-devsnapshot needsSNAPSHOTS_UPDATE="^deploys/contract_fail_code_copy$"once this release is merged.reth-devnet(Prague, as on mainnet and Hoodi): 84 passing, 0 failing, 54 pending.Compare blockspassed.reth-devrun also failedcalls/nested_fail_with_native_transferandsuicide/create_contract_kill_it_and_try_to_call_within_same_call. A call that fails on insufficient balance reported its whole gas limit as consumed instead of 0. Cause: evm2 narrowedInstrStop::is_revert()to theREVERTopcode and moved the old meaning tois_frame_revert(). This affected every fork, Prague included. It is fixed inf557f816dwith a regression test, and both tests pass in the run above.Commands (from a
streamingfast/battlefield-ethereumcheckout atccbad7c,fireethv2.24.1):CHANGELOG