Skip to content

Support set revsion value on chart for istio #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tuteng wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support set revsion value on chart for istio #1264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions charts/sn-platform-slim/templates/bookkeeper/bookkeeper-cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,9 @@ spec:
mtls:
mode: permissive
{{- end }}
{{- if .Values.istio.revision }}
revision: {{ .Values.istio.revision }}
{{- end }}
{{- end }}
config:
{{- with .Values.bookkeeper.rackAwareTopologyLabels }}
Expand Down
3 changes: 3 additions & 0 deletions charts/sn-platform-slim/templates/broker/broker-cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,9 @@ spec:
mtls:
mode: permissive
{{- end }}
{{- if .Values.istio.revision }}
revision: {{ .Values.istio.revision }}
{{- end }}
gateway:
selector:
{{- include "pulsar.istio.gateway.selector" . | indent 8 }}
Expand Down
3 changes: 3 additions & 0 deletions charts/sn-platform-slim/templates/zookeeper/zookeeper-cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,9 @@ spec:
mtls:
mode: permissive
{{- end }}
{{- if .Values.istio.revision }}
revision: {{ .Values.istio.revision }}
{{- end }}
{{- end }}
config:
serverCnxnFactory: {{ .Values.zookeeper.serverCnxnFactory }}
Expand Down
3 changes: 3 additions & 0 deletions charts/sn-platform-slim/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2539,6 +2539,9 @@ istio:
# - ambient: Sidecar-less data plane using ztunnel for L4 mTLS (~70-80% resource savings)
# Leave empty for default behavior (sidecar mode)
dataplaneMode: ""
# Istio revision to use for control plane injection
# When set, this revision will be applied to broker, bookkeeper, and zookeeper components
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment states that the revision will be applied to "broker, bookkeeper, and zookeeper components", but the proxy component also has an istio configuration section and would benefit from revision support for consistency. Consider updating the proxy-cluster.yaml template to include the revision field in its istio section, and update this comment to reflect all components that support the revision field.

Suggested change
# When set, this revision will be applied to broker, bookkeeper, and zookeeper components
# When set, this revision will be applied to all components that support Istio revision configuration

Copilot uses AI. Check for mistakes.
revision: ""
gateway:
# gateway selector if it's not `istio: ingressgateway`
selector: {}
Expand Down
3 changes: 3 additions & 0 deletions charts/sn-platform/templates/broker/broker-cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,9 @@ spec:
mtls:
mode: permissive
{{- end }}
{{- if .Values.istio.revision }}
revision: {{ .Values.istio.revision }}
{{- end }}
gateway:
selector:
{{- include "pulsar.istio.gateway.selector" . | indent 8 }}
Expand Down
3 changes: 3 additions & 0 deletions charts/sn-platform/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2921,6 +2921,9 @@ istio:
# mergeMetrics should be enabled if you want to scrape pulsar metrics from an external prometheus not running on Istio
# prometheus and grafana will not be Istio injected if mergeMetrics is enabled
mergeMetrics: false
# Istio revision to use for control plane injection
# When set, this revision will be applied to broker, bookkeeper, and zookeeper components
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment states that the revision will be applied to "broker, bookkeeper, and zookeeper components", but the proxy component also has an istio configuration section and would benefit from revision support for consistency. Consider updating the proxy-cluster.yaml template to include the revision field in its istio section, and update this comment to reflect all components that support the revision field.

Suggested change
# When set, this revision will be applied to broker, bookkeeper, and zookeeper components
# When set, this revision will be applied to broker, bookkeeper, zookeeper, and proxy components

Copilot uses AI. Check for mistakes.
revision: ""
gateway:
# gateway selector if it's not `istio: ingressgateway`
selector: {}
Expand Down
Loading