feat: Migrate to a standard name for adding extra tags#186
Merged
mitch-hamm merged 1 commit intomasterfrom Apr 29, 2026
Merged
Conversation
Contributor
|
@mitch-hamm:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
Bot
added
doc-info-missing
Contributor
|
@mitch-hamm:Thanks for providing doc info! |
dpappa
approved these changes
Apr 28, 2026
mitch-hamm
pushed a commit
that referenced
this pull request
Apr 29, 2026
🤖 I have created a release *beep* *boop* --- ## [4.8.0](v4.7.0...v4.8.0) (2026-04-29) ### Features * Migrate to a standard name for adding extra tags ([#186](#186)) ([1c0c27d](1c0c27d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The existing
extra_aws_tagsvariable inmodules/dns-bucketandextra_aws_tags/tagsvariables inmodules/vpcare inconsistently named across our Terraform module suite. This PR standardizes onadditional_tagsas the canonical variable name for passing extra resource tags, matching the convention already used in the root module (main.tf,variables.tf).This change supports an ongoing migration where callers can transition from
extra_aws_tags/tagstoadditional_tagswithout a breaking change.Modifications
modules/dns-bucket/variables.tf: Addedadditional_tagsvariable. Deprecatedextra_aws_tags. Updatedlocal.tagsto merge both (extra_aws_tagsthenadditional_tags, soadditional_tagstakes precedence during transition).modules/vpc/variables.tf: Addedadditional_tagsvariable. Deprecatedtags. Addedlocal.tagsthat merges both.modules/vpc/main.tf: Updated all resource tag expressions to uselocal.tagsinstead ofvar.tagsdirectly.Backward compatible — existing callers passing
extra_aws_tagsortagscontinue to work unchanged.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
no-need-docNo user-facing behavior changes — variable additions with backward-compatible defaults.