Skip to content

chore: remove images/ + scrub linuxserver code references#262

Merged
JoshuaAFerguson merged 1 commit into
mainfrom
chore/remove-images-dir
Apr 25, 2026
Merged

chore: remove images/ + scrub linuxserver code references#262
JoshuaAFerguson merged 1 commit into
mainfrom
chore/remove-images-dir

Conversation

@JoshuaAFerguson

Copy link
Copy Markdown
Member

Summary

Pairs with streamspace-templates#2 which now owns the chrome-selkies image source and build pipeline. This repo no longer ships image sources of its own.

Removed

  • `images/` — moved to `streamspace-templates/images/`

Code cleanup (linuxserver references that survived #260)

  • `agents/k8s-agent/agent_k8s_operations.go` — deleted `getTemplateImage()`. It was a hardcoded `templateName→linuxserver-image` map with no production callers (only its own test referenced it).
  • `agents/k8s-agent/agent_test.go` — deleted `TestGetTemplateImage`.
  • `api/internal/api/handlers.go` — `detectStreamingProtocol()` simplified from 99 lines of base-image pattern matching (linuxserver/kasmweb/guacamole/x2go) down to honoring `spec.streamingProtocol` + `spec.ports[0].containerPort` with selkies/8080 defaults. The platform is Selkies-only; there is no longer protocol heterogeneity to detect.
  • `api/internal/api/handlers.go` — fallback baseImage in the test-helper path: `lscr.io/linuxserver/firefox:latest` → `ghcr.io/streamspace-dev/chrome-selkies:latest`.
  • `api/internal/sync/parser.go` — doc-comment example uses chrome-selkies.
  • `ui/src/mocks/handlers.ts` + `ui/e2e/fixtures/api.fixture.ts` — `MOCK_TEMPLATES` collapsed to a single chrome-selkies entry. Legacy chromium/firefox/vscode mocks pointed at linuxserver images that don't run on the Selkies-only pipeline.

Verified

  • `go build ./...` clean: api / k8s-agent / docker-agent
  • `npm run build` clean: ui
  • `go test ./...` clean for api packages

Remaining (deferred to docs phase)

linuxserver references still live in `docs/`, READMEs, ADRs, helm chart templates, and CRD example annotations. They will be reconciled in the docs sweep.

Pairs with streamspace-templates#2 which now owns the chrome-selkies
image source and build pipeline. This repo no longer ships image
sources of its own.

Removed:
- images/                     moved to streamspace-templates/images/

Code cleanup (linuxserver references that survived #260):
- agents/k8s-agent/agent_k8s_operations.go
                              deleted getTemplateImage() — a hardcoded
                              templateName→linuxserver-image map that
                              had no production callers (only its own
                              test referenced it).
- agents/k8s-agent/agent_test.go
                              deleted TestGetTemplateImage.
- api/internal/api/handlers.go
                              detectStreamingProtocol() simplified from
                              99 lines of base-image pattern matching
                              (linuxserver/kasmweb/guacamole/x2go) down
                              to honoring spec.streamingProtocol +
                              spec.ports[0].containerPort with selkies/8080
                              defaults. The platform is Selkies-only;
                              there is no longer protocol heterogeneity
                              to detect.
- api/internal/api/handlers.go
                              fallback baseImage in the test-helper path:
                              lscr.io/linuxserver/firefox:latest →
                              ghcr.io/streamspace-dev/chrome-selkies:latest
- api/internal/sync/parser.go
                              doc-comment example uses chrome-selkies.
- ui/src/mocks/handlers.ts + ui/e2e/fixtures/api.fixture.ts
                              MOCK_TEMPLATES collapsed to a single
                              chrome-selkies entry. The legacy
                              chromium/firefox/vscode mocks pointed at
                              linuxserver images that don't run on the
                              Selkies-only pipeline.

Verified: api / k8s-agent / docker-agent / ui all build clean,
api unit tests pass.

Remaining linuxserver references live in docs/, READMEs, ADRs, helm
chart templates, and CRD example annotations. They will be reconciled
in the docs phase of the cleanup plan.
@JoshuaAFerguson JoshuaAFerguson merged commit 0cca520 into main Apr 25, 2026
@JoshuaAFerguson JoshuaAFerguson deleted the chore/remove-images-dir branch April 25, 2026 19:41
@github-actions github-actions Bot added documentation Improvements or additions to documentation testing component:backend Backend API (Go) component:ui Frontend UI (React) component:k8s-agent Kubernetes Agent labels Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:backend Backend API (Go) component:k8s-agent Kubernetes Agent component:ui Frontend UI (React) documentation Improvements or additions to documentation testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant