chore: remove images/ + scrub linuxserver code references#262
Merged
Conversation
Pairs with streamspace-templates#2 which now owns the chrome-selkies image source and build pipeline. This repo no longer ships image sources of its own. Removed: - images/ moved to streamspace-templates/images/ Code cleanup (linuxserver references that survived #260): - agents/k8s-agent/agent_k8s_operations.go deleted getTemplateImage() — a hardcoded templateName→linuxserver-image map that had no production callers (only its own test referenced it). - agents/k8s-agent/agent_test.go deleted TestGetTemplateImage. - api/internal/api/handlers.go detectStreamingProtocol() simplified from 99 lines of base-image pattern matching (linuxserver/kasmweb/guacamole/x2go) down to honoring spec.streamingProtocol + spec.ports[0].containerPort with selkies/8080 defaults. The platform is Selkies-only; there is no longer protocol heterogeneity to detect. - api/internal/api/handlers.go fallback baseImage in the test-helper path: lscr.io/linuxserver/firefox:latest → ghcr.io/streamspace-dev/chrome-selkies:latest - api/internal/sync/parser.go doc-comment example uses chrome-selkies. - ui/src/mocks/handlers.ts + ui/e2e/fixtures/api.fixture.ts MOCK_TEMPLATES collapsed to a single chrome-selkies entry. The legacy chromium/firefox/vscode mocks pointed at linuxserver images that don't run on the Selkies-only pipeline. Verified: api / k8s-agent / docker-agent / ui all build clean, api unit tests pass. Remaining linuxserver references live in docs/, READMEs, ADRs, helm chart templates, and CRD example annotations. They will be reconciled in the docs phase of the cleanup plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pairs with streamspace-templates#2 which now owns the chrome-selkies image source and build pipeline. This repo no longer ships image sources of its own.
Removed
Code cleanup (linuxserver references that survived #260)
Verified
Remaining (deferred to docs phase)
linuxserver references still live in `docs/`, READMEs, ADRs, helm chart templates, and CRD example annotations. They will be reconciled in the docs sweep.