Skip to content

Fix GitHub Action build failures #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshuaAFerguson merged 1 commit into from
Nov 16, 2025
Merged

Fix GitHub Action build failures #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions api/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
ARG TARGETARCH

# Install build dependencies
RUN apk add --no-cache git make ca-certificates

Check failure on line 12 in api/Dockerfile

View workflow job for this annotation

GitHub Actions / Dockerfile Linting (api) 

DL3018 warning: Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`

WORKDIR /workspace

Expand All @@ -23,8 +23,11 @@
COPY cmd/ cmd/
COPY internal/ internal/

# Tidy modules to ensure go.mod and go.sum are up to date
RUN go mod tidy

# Build the API server with version info for the target architecture
RUN CGO_ENABLED=0 GOOS=linux GOARCH=${TARGETARCH} go build -a \

Check failure on line 30 in api/Dockerfile

View workflow job for this annotation

GitHub Actions / Dockerfile Linting (api) 

DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
-ldflags "-w -s -X main.version=${VERSION} -X main.commit=${COMMIT} -X main.buildDate=${BUILD_DATE}" \
-o api-server cmd/main.go

Expand All @@ -38,7 +41,7 @@
LABEL org.opencontainers.image.source="https://github.com/yourusername/streamspace"

# Install runtime dependencies
RUN apk add --no-cache ca-certificates git tzdata wget

Check failure on line 44 in api/Dockerfile

View workflow job for this annotation

GitHub Actions / Dockerfile Linting (api) 

DL3018 warning: Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`

WORKDIR /app

Expand Down
3 changes: 3 additions & 0 deletions controller/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ COPY api/ api/
COPY controllers/ controllers/
COPY pkg/ pkg/

# Tidy modules to ensure go.mod and go.sum are up to date
RUN go mod tidy

# Build the controller with version info for the target architecture
RUN CGO_ENABLED=0 GOOS=linux GOARCH=${TARGETARCH} go build -a \
-ldflags "-w -s -X main.version=${VERSION} -X main.commit=${COMMIT} -X main.buildDate=${BUILD_DATE}" \
Expand Down
Loading