Skip to content

Fix duplicate route handler registration panic #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshuaAFerguson merged 2 commits into from
Nov 17, 2025
Merged

Fix duplicate route handler registration panic #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42a3840
fix(api): remove duplicate session activity GET route registration
claude Nov 16, 2025
1f7ed24
fix(api): remove duplicate WebSocket /ws/sessions route registration
claude Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion api/cmd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,13 +781,14 @@ func setupRoutes(router *gin.Engine, h *api.Handler, userHandler *handlers.UserH
ws := router.Group("/api/v1/ws")
ws.Use(authMiddleware)
{
ws.GET("/sessions", h.SessionsWebSocket)
// NOTE: /ws/sessions is now handled by websocketHandler.RegisterRoutes() below
ws.GET("/cluster", operatorMiddleware, h.ClusterWebSocket)
ws.GET("/logs/:namespace/:pod", operatorMiddleware, h.LogsWebSocket)
ws.GET("/enterprise", handlers.HandleEnterpriseWebSocket) // Real-time enterprise features
}

// Real-time updates via WebSocket - using dedicated handler (all authenticated users)
// Registers: /ws/sessions, /ws/notifications, /ws/metrics, /ws/alerts
websocketHandler.RegisterRoutes(router.Group("/api/v1", authMiddleware))

// Webhook endpoints (HMAC signature validation required)
Expand Down
3 changes: 2 additions & 1 deletion api/internal/handlers/activity.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ func (h *ActivityHandler) RegisterRoutes(router *gin.RouterGroup) {
sessions := router.Group("/sessions")
{
sessions.POST("/:id/heartbeat", h.RecordHeartbeat)
sessions.GET("/:id/activity", h.GetActivity)
// NOTE: GET /:id/activity is now handled by SessionActivityHandler
// which provides more comprehensive activity tracking with database persistence
}
}

Expand Down
Loading