Update code comments to reflect recent changes#59
Merged
JoshuaAFerguson merged 1 commit intoNov 17, 2025
Merged
Conversation
Update code comments to better explain recent WebSocket-related changes: - CORS middleware: Add comprehensive documentation explaining WebSocket headers required for real-time features (Upgrade, Connection, Sec-WebSocket-Key, etc.) and their purpose in the handshake process - Auth middleware: Document WebSocket-specific error handling that returns status codes only (no JSON body) to maintain protocol compatibility with WebSocket upgrader These comment improvements reflect the recent fixes for WebSocket connections (commits 1c9be1f, 9e02842) and clarify implementation details for future developers.
JoshuaAFerguson
deleted the
claude/update-code-comments-01SuXoHgLtdgaa7ePMdaKaRr
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update code comments to better explain recent WebSocket-related changes:
CORS middleware: Add comprehensive documentation explaining WebSocket headers required for real-time features (Upgrade, Connection, Sec-WebSocket-Key, etc.) and their purpose in the handshake process
Auth middleware: Document WebSocket-specific error handling that returns status codes only (no JSON body) to maintain protocol compatibility with WebSocket upgrader
These comment improvements reflect the recent fixes for WebSocket connections (commits 1c9be1f, 9e02842) and clarify implementation details for future developers.