Fix undefined error variable in stubs#76
Merged
JoshuaAFerguson merged 3 commits intoNov 18, 2025
Conversation
Fixed compilation errors in GetMetrics function where the err variable was being used outside its scope. Declared err at function level and updated assignments from := to = in nested blocks. Fixes: - internal/api/stubs.go:735: undefined: err - internal/api/stubs.go:744: undefined: err - internal/api/stubs.go:745: undefined: err - internal/api/stubs.go:758: undefined: err - internal/api/stubs.go:765: undefined: err - internal/api/stubs.go:766: undefined: err
Fixed compilation errors by declaring nodes and pods variables at the function level alongside err. This allows them to be properly assigned within nested blocks without redeclaration. Fixes: - internal/api/stubs.go:689: undefined: nodes - internal/api/stubs.go:694: undefined: nodes - internal/api/stubs.go:697: undefined: nodes - internal/api/stubs.go:719: undefined: pods - internal/api/stubs.go:721: undefined: pods
Add optional chaining to safely check if userGroups.groups exists before accessing its length property. This prevents the TypeError: "can't access property 'length', b.groups is undefined" when the groups property is not returned by the API.
JoshuaAFerguson
deleted the
claude/fix-stubs-error-var-017QC8gWhzpztaUSwiDeo1az
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.