test: meaningful upmix test (decode + assert surround energy) - #5
Merged
Conversation
- Remove test_config.cpp (Config{}.upmix=="surround" was a literal==literal
tautology) and the weak "upmix yields bursts" case (only proved no-crash).
- Add test_upmix.cpp: encode anti-phase stereo, DECODE the AC3 back via the
spdif demuxer + AC3 decoder, and assert the surround channels carry real
energy with upmix=surround (~0.147 RMS) but are silent with upmix=off (~7e-7).
Self-validating: fails if the upmix is a no-op.
Note: writing this caught a real test bug (decoding the primed-silence frame),
which a tautological test would have hidden.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the tautological config-default test and the weak burst-existence test with a behavioral one: decode the AC3 output and assert upmix=surround puts energy in the surround channels (on=0.147 vs off=7e-7 RMS). Removed test-theatre per directive.