Skip to content

Capture stderr when handler closes unexpectedly #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stringintech merged 2 commits into from
Nov 28, 2025
Merged

Capture stderr when handler closes unexpectedly #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4cb7a2
Capture stderr when handler closes unexpectedly
stickies-v Nov 27, 2025
d4cfd70
Force stderr to close before capturing it
stringintech Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions runner/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,16 @@ func (tr *TestRunner) SendRequest(req Request) (*Response, error) {
if err := tr.stdout.Err(); err != nil {
return nil, fmt.Errorf("failed to read response: %w", err)
}
// Handler closed stdout prematurely.
// Kill the process immediately to force stderr to close.
// Without this, there's a rare scenario where stdout closes but stderr remains open,
// causing io.ReadAll(tr.stderr) below to block indefinitely waiting for stderr EOF.
if tr.cmd.Process != nil {
tr.cmd.Process.Kill()
}
if stderrOut, err := io.ReadAll(tr.stderr); err == nil && len(stderrOut) > 0 {
return nil, fmt.Errorf("handler closed unexpectedly: %s", bytes.TrimSpace(stderrOut))
}
return nil, fmt.Errorf("handler closed unexpectedly")
}
respLine := tr.stdout.Text()
Expand Down
Loading