fix(token-meter): stop consuming abandoned streams - #509
Open
rioyu123 wants to merge 1 commit into
Open
Conversation
|
|
1 similar comment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The OpenAI and Anthropic streaming meters currently split the SDK stream and drain a metering branch in an unawaited background task. The SDK
tee()iterators do not propagatereturn(), so breaking out of the returned stream does not close the source request. The second OpenAI split also retains results for a peek branch that stops after its first chunk.This change meters each provider inline through a single SDK
Streamwrapper. Usage is accumulated as chunks pass to the caller and logged after normal completion. Early termination now closes the source iterator, while the returned value keeps the provider stream class and its stream methods. Provider SDKs remain optional runtime dependencies.Early-cancelled streams are no longer drained solely to obtain final usage metadata. If the consumer stops before that metadata arrives, the source is closed and no complete usage event is emitted from unavailable final metadata.
Testing