Skip to content

change publish to sonatype - #501

Merged
avibryant merged 6 commits into
stripe:developfrom
kailuowang:stripe
May 21, 2021
Merged

change publish to sonatype#501
avibryant merged 6 commits into
stripe:developfrom
kailuowang:stripe

Conversation

@kailuowang

@kailuowang kailuowang commented May 13, 2021

Copy link
Copy Markdown
Contributor

to actually publish, two env variables are needed
"SONATYPE_USERNAME" and "SONATYPE_PASSWORD"
These can be set to a sonatype login token, which can be generated following the steps here

@kailuowang

Copy link
Copy Markdown
Contributor Author

these tests seem to be failing prior to these changes in my other PR as well.

@avibryant

Copy link
Copy Markdown
Collaborator

@kailuowang those tests are sensitive to RNG. I wonder if maybe the JVM being used to run the tests in CI has changed or and its RNG is different? Or alternatively something around FP math settings?

@kailuowang

Copy link
Copy Markdown
Contributor Author

Jvm was changed since the old gh action step is no longer supported. I am using the official Scala action step now. Can we change the tests to expect the new values?

@avibryant

Copy link
Copy Markdown
Collaborator

@kailuowang ok, yes, that's a bit of a lengthy process because we have to re-run the Simulation-Based Calibration to make sure the posteriors still look ok, but I have reproduced the test failures by switching to JDK 11 on my machine so I can work on that.

@avibryant

Copy link
Copy Markdown
Collaborator

@kailuowang should pass after merging with #502

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kailuowang
❌ avibryant
You have signed the CLA already but the status is still pending? Let us recheck it.

@kailuowang

Copy link
Copy Markdown
Contributor Author

@avibryant I merged in your commits, the build passes, but the CLAssistant got confused.

@avibryant
avibryant merged commit 39e312c into stripe:develop May 21, 2021
@kailuowang
kailuowang deleted the stripe branch May 21, 2021 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants