fix: register event_blobs in conversation bundles#27
Open
pandego wants to merge 1 commit intostrongdm:mainfrom
Open
fix: register event_blobs in conversation bundles#27pandego wants to merge 1 commit intostrongdm:mainfrom
pandego wants to merge 1 commit intostrongdm:mainfrom
Conversation
Signed-off-by: pandego <7780875+pandego@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Register
event_blobsin the canonical conversation registry bundles used by fixtures andcxtx, and add a regression test that proves typed projection now surfaces the field.What changed?
event_blobsat AssistantTurn tag11incxtx/src/conversation_registry_bundle.jsonfixtures/registry/conversation-bundle.jsonto mirror the canonical v3 conversation bundle instead of the stale 4-field samplescripts/generate-fixtures.shto copy the canonical bundle into fixtures so the two files stay alignednested_event_blobs_field_projects_in_typed_viewcoverage inserver/tests/registry_projection.rsWhy?
Typed HTTP projection only exposes registered fields. Without tag 11 in the published conversation bundle,
event_blobsstays hidden unless clients opt into unknown-field fallbacks.How to test?
cd server && cargo fmt --checkcd server && cargo test --test registry_projectioncxtx/src/conversation_registry_bundle.jsonandfixtures/registry/conversation-bundle.jsonChecklist
cargo test,go test ./...,pnpm test)cargo clippy,cargo fmt,golangci-lint run,pnpm lint)Related Issues
Fixes #18
Additional Notes
I kept this scoped to registry publication and projection coverage. I did not try to register the full external Amplifier schema beyond the missing
event_blobsfield.