fix: build strings for complex types differently for Terraform/Packer commands#5
Merged
chris-aavang merged 2 commits intomasterfrom Mar 9, 2026
Conversation
63c69b7 to
9b35b26
Compare
Simply str()'ing complex types does not create strings in the format that Terraform requires. I also tested and fixed dicts. The fixes apply to Packer as well.
9b35b26 to
a1dca39
Compare
uadnan
previously approved these changes
Mar 6, 2026
Member
uadnan
left a comment
There was a problem hiding this comment.
Looking good. Just a minor suggestion
Contributor
Author
|
Thank you, Adnan. I'll merge and publish to PyPI on Monday. If you have any other changes you'd like, feel free to make them yourself or comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(terraform,packer,cli): build strings for lists and dicts differently
Simply str()'ing complex types does not create strings in the format that Terraform requires. I also tested and fixed dicts. The fixes apply to Packer as well.
Also mentioned in the docs are
setsandobjects. In my testing, the changes formapandlisthandle those as well. Makes sense;objectsaredictswith defined keys, andsetsare uniquelist's.Type of Change
Checklist
Checklist for Reviewers