Skip to content

feat: support for ByteProperty in MapProperty and implement writeByte… #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krushna06 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: support for ByteProperty in MapProperty and implement writeByte… #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/converter/properties/MapProperty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import NoneProperty from "./NoneProperty.js";
import {writeBytes, writeInt32, writeFloat32, writeString, writeUint32} from "../value-writer.js";
import {writeBytes, writeInt32, writeFloat32, writeString, writeUint32, writeByte} from "../value-writer.js";
import {assignPrototype} from "../converter.js";

class MapProperty {
Expand Down Expand Up @@ -33,6 +33,7 @@ class MapProperty {
break;

case "StrProperty":
case "NameProperty":
currentKey = savReader.readString();
break;

Expand Down Expand Up @@ -64,6 +65,10 @@ class MapProperty {
currentValue = savReader.readBoolean();
break;

case "ByteProperty":
currentValue = savReader.readString();
break;

case "StrProperty":
currentValue = savReader.readString();
break;
Expand Down Expand Up @@ -98,6 +103,7 @@ class MapProperty {
break;

case "StrProperty":
case "NameProperty":
byteArrayContent = new Uint8Array([...byteArrayContent, ...writeString(currentKey)]);
break;

Expand Down Expand Up @@ -125,6 +131,10 @@ class MapProperty {
byteArrayContent = new Uint8Array([...byteArrayContent, ...writeString(currentValue)]);
break;

case "ByteProperty":
byteArrayContent = new Uint8Array([...byteArrayContent, ...writeString(currentValue)]);
break;

case "BoolProperty":
if (currentValue === true) {
byteArrayContent = new Uint8Array([...byteArrayContent, 0x01]);
Expand Down
4 changes: 4 additions & 0 deletions src/converter/value-writer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ export function writeFloat32(value) {
return array;
}

export function writeByte(value) {
return new Uint8Array([value]);
}

export function writeFloat64(value) {
const array = new Uint8Array(8);
new DataView(array.buffer).setFloat64(0, value, true);
Expand Down