Conversation
Signed-off-by: Soren Soe <2106410+stsoe@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const std::string hello() | ||
| { | ||
| std::string str = "hello"; | ||
| X x(str); |
There was a problem hiding this comment.
warning: variable name 'x' is too short, expected at least 3 characters [readability-identifier-length]
X x(str);
^
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| { | ||
| std::string m_string; | ||
| public: | ||
| X(const std::string& str) : m_string(str) {} |
There was a problem hiding this comment.
warning: pass by value and use std::move [modernize-pass-by-value]
src/hello.cpp:2:
+ #include <utility>
Suggested change
| X(const std::string& str) : m_string(str) {} | |
| X(std::string str) : m_string(std::move(str)) {} |
| { | ||
| std::string m_string; | ||
| public: | ||
| X(const std::string& str) : m_string(str) {} |
There was a problem hiding this comment.
warning: single-argument constructors must be marked explicit to avoid unintentional implicit conversions [hicpp-explicit-conversions]
Suggested change
| X(const std::string& str) : m_string(str) {} | |
| explicit X(const std::string& str) : m_string(str) {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.