This repository was archived by the owner on Aug 15, 2026. It is now read-only.
Fix bash import issues and add dual-command toggle - #2
Merged
Merged
Conversation
…ggle
Reverse parser: reject shell variables ($VAR/${VAR}), skip non-modifying
commands gracefully, infer default zone "public" for zone-less commands,
broaden reload matching. Generator: add runtime mode that emits paired
permanent+runtime commands without --reload. UI: Runtime toggle checkbox
with localStorage persistence.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$VAR,${VAR},$(...)) with clear error instead of importing them as literal strings--get-*,--list-*,--query-*,--state,--version,--runtime-to-permanent,--check-config) now skipped gracefully instead of erroring--add-service=httpwithout--zone) infer default zonepublic--reloadTest plan
$VAR— should show error, not import silently--zone— should import intopubliczonefirewall-cmd --list-all— should show as skipped, not error--reload--reload(existing behavior)🤖 Generated with Claude Code