Added Approve All Button in Join Requests tab #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for stuyepsilon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
SnowyNate
requested changes
Nov 9, 2025
Member
SnowyNate
left a comment
SnowyNate
left a comment
There was a problem hiding this comment.
- This code redundantly uses logic for approving a member which is already in
src\modules\stuyactivities\orgs\org_admin\components\PendingMember.tsx, please find a more efficient way to solve this issue. - The styling of the button is perfect and the feature works, though it causes a "No join requests to approve." message when clicking on it.
Restyled Added Approve All Button in Join Requests tab
SnowyNate
requested changes
Nov 11, 2025
Member
SnowyNate
left a comment
SnowyNate
left a comment
There was a problem hiding this comment.
Like before, I feel these changes are too "radical". This is just removing the approve logic from the component for it, and putting it in the page. Please check discord so we can discuss how to proceed about this and future issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226