perf: Cache AST so we only re-parse files which have changed#2174
Draft
jbencin-stacks wants to merge 1 commit intostx-labs:mainfrom
Draft
perf: Cache AST so we only re-parse files which have changed#2174jbencin-stacks wants to merge 1 commit intostx-labs:mainfrom
jbencin-stacks wants to merge 1 commit intostx-labs:mainfrom
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Collaborator
|
Hey @jbencin-stacks Additionally, I think it might be a similar concept as the existing If we would benefit from iterating on this existing data instead of adding a new cache. I haven't look at these code path in a while, so that's just some thought that I have after a quick review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cache AST by file content hash so that we don't
This will make VSCode extension more responsive as it won't re-parse the entire project on each save. It won't help
clarinet checkCLI command thoughFixes: #604
Breaking change?
No