Skip to content

fix: issue where pasing no params would fail the walletconnect connection#476

Merged
jannik-stacks merged 2 commits intostx-labs:mainfrom
tomiir:fix/wc-request-no-params
Dec 30, 2025
Merged

fix: issue where pasing no params would fail the walletconnect connection#476
jannik-stacks merged 2 commits intostx-labs:mainfrom
tomiir:fix/wc-request-no-params

Conversation

@tomiir
Copy link
Copy Markdown
Contributor

@tomiir tomiir commented Nov 18, 2025

Description

  • Adds an extra check on WC connector to validate that params are being passed in before trying to access it.
  • If params were undefined, this would fail the connection call.

Example:
As a Stacks developer I would like to use my WC wallet without needing to specify network parameters explicitly

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other

Does this introduce a breaking change?

No

Are documentation updates required?

WC Connector documentation should be updated

  • Link to documentation updates:

Testing information

Checklist

  • Code is commented where needed
  • Unit test coverage for new or modified code paths => Where should I?
  • Changelog is updated
  • Tag @janniks for review

Copy link
Copy Markdown
Collaborator

@jannik-stacks jannik-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Thanks for this

@jannik-stacks jannik-stacks merged commit 6239566 into stx-labs:main Dec 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants